Skip to content

feat_favorites_filter#1985

Merged
Mbeaulne merged 1 commit intomasterfrom
03-23-feat_favorites_filter
Apr 10, 2026
Merged

feat_favorites_filter#1985
Mbeaulne merged 1 commit intomasterfrom
03-23-feat_favorites_filter

Conversation

@Mbeaulne
Copy link
Copy Markdown
Collaborator

@Mbeaulne Mbeaulne commented Mar 23, 2026

Description

Added search functionality to the Favorites section, allowing users to filter favorites by name or ID. The search input includes a search icon and a clear button that appears when there's a query. The pagination logic has been updated to work with filtered results, automatically resetting to the first page when searching.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  1. Navigate to the Home page with existing favorites
  2. Verify the search input appears above the favorites list
  3. Type in the search field to filter favorites by name or ID
  4. Confirm the clear button (X) appears when typing and clears the search when clicked
  5. Test pagination with filtered results to ensure it resets appropriately
  6. Verify case-insensitive search functionality works correctly

Additional Comments

The search functionality filters favorites in real-time and automatically resets pagination to the first page when the search query changes. The search is case-insensitive and matches both favorite names and IDs.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 23, 2026

🎩 To tophat this PR:

You can add the following URL parameter to your browser to tophat this PR:

`?tophat_location=03-23-feat_favorites_filter/42d8a5b`

@Mbeaulne
Copy link
Copy Markdown
Collaborator Author

Reviewer note: This PR adds a search filter to FavoritesSection.tsx — the same chip-based component that is deleted in #1996 and again in #1998. This change doesn't survive the stack.

The final favorites view is in DashboardFavoritesView.tsx (built in #1998). Feel free to skim this one.

@Mbeaulne Mbeaulne marked this pull request as ready for review March 30, 2026 18:23
@Mbeaulne Mbeaulne requested a review from a team as a code owner March 30, 2026 18:23
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_filter branch from dabe28b to f043754 Compare April 1, 2026 17:49
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_homepage_section branch 2 times, most recently from 557cdac to 7a06970 Compare April 1, 2026 18:34
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_filter branch from f043754 to 1c5cd1b Compare April 1, 2026 18:34
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_homepage_section branch from 7a06970 to 3e93860 Compare April 1, 2026 18:37
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_filter branch 3 times, most recently from 90c8d7b to f9e6d43 Compare April 2, 2026 16:35
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_homepage_section branch from 3b5574d to 95b5dcb Compare April 2, 2026 19:19
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_filter branch from f9e6d43 to 5f064d8 Compare April 2, 2026 19:19
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_homepage_section branch from 95b5dcb to 097fcf7 Compare April 6, 2026 13:12
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_filter branch from 5f064d8 to 1bad5de Compare April 6, 2026 13:12
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_homepage_section branch from 097fcf7 to 8676de7 Compare April 8, 2026 17:25
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_filter branch from 1bad5de to 8025d09 Compare April 8, 2026 17:25
This was referenced Apr 8, 2026
Copy link
Copy Markdown
Collaborator

@camielvs camielvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skipping & autoapproving as directed - though I would have preferred for the stack to be sufficiently massaged that PRs like this are not needed

@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_filter branch 2 times, most recently from 989b473 to 42b8056 Compare April 10, 2026 19:09
Copy link
Copy Markdown
Collaborator Author

Mbeaulne commented Apr 10, 2026

Merge activity

  • Apr 10, 8:38 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 10, 8:53 PM UTC: Graphite rebased this pull request as part of a merge.
  • Apr 10, 8:55 PM UTC: @Mbeaulne merged this pull request with Graphite.

@Mbeaulne Mbeaulne changed the base branch from 03-23-feat_favorites_homepage_section to graphite-base/1985 April 10, 2026 20:50
@Mbeaulne Mbeaulne changed the base branch from graphite-base/1985 to master April 10, 2026 20:52
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_filter branch from 42b8056 to 42d8a5b Compare April 10, 2026 20:53
@Mbeaulne Mbeaulne merged commit e575ec2 into master Apr 10, 2026
16 of 17 checks passed
@Mbeaulne Mbeaulne deleted the 03-23-feat_favorites_filter branch April 10, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants