Skip to content

feat_favorites_filter #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mbeaulne merged 1 commit into from
Apr 10, 2026
Merged

feat_favorites_filter #1985

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 43 additions & 2 deletions src/components/Home/FavoritesSection/FavoritesSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { useState } from "react";

import { Button } from "@/components/ui/button";
import { Icon } from "@/components/ui/icon";
import { Input } from "@/components/ui/input";
import { BlockStack, InlineStack } from "@/components/ui/layout";
import { Heading, Paragraph, Text } from "@/components/ui/typography";
import {
Expand Down Expand Up @@ -64,10 +65,20 @@ const FavoriteChip = ({
export const FavoritesSection = () => {
const { favorites, removeFavorite } = useFavorites();
const [page, setPage] = useState(0);
const [query, setQuery] = useState("");

const totalPages = Math.ceil(favorites.length / PAGE_SIZE);
const normalizedQuery = query.trim().toLowerCase();
const filtered = normalizedQuery
? favorites.filter(
(favorite) =>
favorite.id.toLowerCase().includes(normalizedQuery) ||
favorite.name.toLowerCase().includes(normalizedQuery),
)
: favorites;

const totalPages = Math.ceil(filtered.length / PAGE_SIZE);
const safePage = Math.min(page, Math.max(0, totalPages - 1));
const paginated = favorites.slice(
const paginated = filtered.slice(
safePage * PAGE_SIZE,
(safePage + 1) * PAGE_SIZE,
);
Expand All @@ -85,6 +96,36 @@ export const FavoritesSection = () => {
</Paragraph>
) : (
<BlockStack gap="2">
<div className="relative w-48">
<Icon
name="Search"
className="absolute left-3 top-1/2 -translate-y-1/2 text-muted-foreground"
/>
<Input
placeholder="Search by name or ID..."
value={query}
onChange={(e) => {
setPage(0);
setQuery(e.target.value);
}}
className="pl-9 pr-8 w-full"
/>
{query && (
<Button
variant="ghost"
size="icon"
onClick={() => {
setPage(0);
setQuery("");
}}
className="absolute right-2 top-1/2 -translate-y-1/2 size-6 text-muted-foreground hover:text-foreground"
aria-label="Clear search"
>
<Icon name="X" size="sm" />
</Button>
)}
</div>

<InlineStack wrap="wrap" gap="2">
{paginated.map((item) => (
<FavoriteChip
Expand Down
Loading