Skip to content

add favourites to new dashboard#1997

Merged
Mbeaulne merged 1 commit intomasterfrom
03-24-add_favourites_to_new_dashboard
Apr 10, 2026
Merged

add favourites to new dashboard#1997
Mbeaulne merged 1 commit intomasterfrom
03-24-add_favourites_to_new_dashboard

Conversation

@Mbeaulne
Copy link
Copy Markdown
Collaborator

@Mbeaulne Mbeaulne commented Mar 24, 2026

Description

Added a new FavoritesSection component that displays user favorites with search and pagination functionality. The component shows favorite pipelines and runs as clickable chips with different styling, includes a search input to filter by name or ID, and supports pagination for large lists. Connected this component to the dashboard favorites route, replacing the placeholder "Coming Soon" page.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  1. Navigate to the dashboard favorites page
  2. Verify the favorites section displays correctly when no favorites exist
  3. Add some favorite pipelines and runs using the star functionality
  4. Test the search functionality by filtering favorites by name or ID
  5. Verify pagination works correctly when there are more than 10 favorites
  6. Test clicking on favorite chips navigates to the correct pipeline or run
  7. Test removing favorites using the X button on each chip

Additional Comments

The component integrates with the existing useFavorites hook and uses consistent UI components from the design system. Pipeline favorites are styled with violet colors while run favorites use emerald colors for visual distinction.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 24, 2026

🎩 To tophat this PR:

You can add the following URL parameter to your browser to tophat this PR:

`?tophat_location=03-24-add_favourites_to_new_dashboard/345f802`

@Mbeaulne Mbeaulne force-pushed the 03-24-feat_dashboard_latout branch from 064e557 to f9ae351 Compare March 27, 2026 12:41
@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch from d40d065 to 82f814c Compare March 27, 2026 12:41
@Mbeaulne Mbeaulne force-pushed the 03-24-feat_dashboard_latout branch from f9ae351 to 51b9d53 Compare March 27, 2026 13:52
@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch from 82f814c to 722df94 Compare March 27, 2026 13:52
@Mbeaulne Mbeaulne force-pushed the 03-24-feat_dashboard_latout branch from 51b9d53 to 5832abe Compare March 27, 2026 13:58
@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch 2 times, most recently from 4746864 to 77dc4aa Compare March 27, 2026 14:07
@Mbeaulne Mbeaulne force-pushed the 03-24-feat_dashboard_latout branch from 5832abe to 69ab0c9 Compare March 27, 2026 14:07
@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch from 77dc4aa to df0767f Compare March 27, 2026 14:12
@Mbeaulne Mbeaulne mentioned this pull request Mar 27, 2026
3 tasks
@Mbeaulne
Copy link
Copy Markdown
Collaborator Author

Reviewer note: FavoritesSection.tsx re-added here is identical to the version deleted in #1996 — it is deleted again one PR later in #1998 when the design switches from chips to cards.

DashboardFavoritesView.tsx introduced here as a 5-line shell is completely rewritten in #1998. You can treat this PR as a brief stepping stone — the final favorites implementation is in #1998.

@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch from 8ecd3d1 to 8f2572b Compare April 2, 2026 16:35
@Mbeaulne Mbeaulne force-pushed the 03-24-feat_dashboard_latout branch 2 times, most recently from 0709629 to a3b9d5f Compare April 2, 2026 16:41
@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch 2 times, most recently from 2fad661 to 856d5ab Compare April 2, 2026 19:19
@Mbeaulne Mbeaulne force-pushed the 03-24-feat_dashboard_latout branch from a3b9d5f to 3d9963e Compare April 2, 2026 19:19
@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch from 856d5ab to b921f4c Compare April 6, 2026 13:12
@Mbeaulne Mbeaulne force-pushed the 03-24-feat_dashboard_latout branch 2 times, most recently from 68e337b to 718a770 Compare April 8, 2026 17:25
@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch from b921f4c to 38c7b38 Compare April 8, 2026 17:25
@Mbeaulne Mbeaulne force-pushed the 03-24-feat_dashboard_latout branch from 718a770 to c03888b Compare April 8, 2026 19:31
@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch from 38c7b38 to 099fb90 Compare April 8, 2026 19:31
This was referenced Apr 8, 2026
@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch from 099fb90 to fe4405e Compare April 9, 2026 15:54
@Mbeaulne Mbeaulne force-pushed the 03-24-feat_dashboard_latout branch from 1658e18 to 261c9a0 Compare April 9, 2026 16:09
@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch from fe4405e to 0e3871a Compare April 9, 2026 16:09
@Mbeaulne Mbeaulne force-pushed the 03-24-feat_dashboard_latout branch from 261c9a0 to 9069b6c Compare April 9, 2026 16:28
@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch 2 times, most recently from 5ed937c to 8f27324 Compare April 9, 2026 16:56
@Mbeaulne Mbeaulne force-pushed the 03-24-feat_dashboard_latout branch from c64d89d to 4fc353c Compare April 10, 2026 19:09
@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch from 8f27324 to 249c7a1 Compare April 10, 2026 19:09
Copy link
Copy Markdown
Collaborator Author

Mbeaulne commented Apr 10, 2026

Merge activity

  • Apr 10, 8:38 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 10, 9:04 PM UTC: Graphite rebased this pull request as part of a merge.
  • Apr 10, 9:07 PM UTC: @Mbeaulne merged this pull request with Graphite.

@Mbeaulne Mbeaulne changed the base branch from 03-24-feat_dashboard_latout to graphite-base/1997 April 10, 2026 20:59
@Mbeaulne Mbeaulne changed the base branch from graphite-base/1997 to master April 10, 2026 21:02
@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch from 249c7a1 to 345f802 Compare April 10, 2026 21:03
@Mbeaulne Mbeaulne merged commit 445dfa6 into master Apr 10, 2026
15 of 17 checks passed
@Mbeaulne Mbeaulne deleted the 03-24-add_favourites_to_new_dashboard branch April 10, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants