Skip to content

moves app footer#2010

Merged
Mbeaulne merged 1 commit intomasterfrom
03-25-moves_app_footer
Apr 10, 2026
Merged

moves app footer#2010
Mbeaulne merged 1 commit intomasterfrom
03-25-moves_app_footer

Conversation

@Mbeaulne
Copy link
Copy Markdown
Collaborator

@Mbeaulne Mbeaulne commented Mar 25, 2026

Description

This pull request improves the dashboard layout and user experience with several key changes:

  • Dashboard Layout Redesign: Converted the dashboard from a horizontal layout to a full-height sidebar layout with independent scrolling areas
  • Enhanced Sidebar: Added footer links (About, Give feedback, Privacy policy) and version information display in the sidebar
  • Conditional Footer: Modified the root layout to hide the app footer on dashboard pages to prevent layout conflicts
  • RunRow Component Cleanup: Replaced the Paragraph component with a native span element, added proper text color styling, and set a fixed row height

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  1. Navigate to the dashboard pages and verify the new sidebar layout displays correctly
  2. Test scrolling behavior in both the sidebar and main content areas
  3. Verify that footer links in the sidebar open correctly in new tabs
  4. Check that the app footer is hidden on dashboard pages but visible on other pages
  5. Confirm that run rows in the pipeline section display properly with the updated styling

Additional Comments

The layout changes create a more professional dashboard experience with better space utilization and improved navigation. The sidebar now includes helpful footer links and version information while maintaining clean separation between navigation and content areas.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 25, 2026

🎩 To tophat this PR:

You can add the following URL parameter to your browser to tophat this PR:

`?tophat_location=03-25-moves_app_footer/39fd83a`

@Mbeaulne Mbeaulne mentioned this pull request Mar 25, 2026
8 tasks
@Mbeaulne Mbeaulne force-pushed the 03-25-moves_app_footer branch from 7d089d6 to 87e9bd5 Compare March 25, 2026 19:52
@Mbeaulne Mbeaulne force-pushed the 03-24-add_new_section_to_the_side_bar branch from 4e1b9ee to aeb6fa8 Compare March 27, 2026 12:41
@Mbeaulne Mbeaulne force-pushed the 03-25-moves_app_footer branch 3 times, most recently from e5dbbd0 to b427379 Compare March 27, 2026 13:58
@Mbeaulne Mbeaulne force-pushed the 03-24-add_new_section_to_the_side_bar branch from ad26745 to b2e8ad6 Compare March 27, 2026 13:58
@Mbeaulne Mbeaulne force-pushed the 03-25-moves_app_footer branch from b427379 to d1c9f97 Compare March 27, 2026 14:07
@Mbeaulne Mbeaulne force-pushed the 03-24-add_new_section_to_the_side_bar branch 2 times, most recently from 81a314c to d8285d7 Compare March 27, 2026 14:12
@Mbeaulne Mbeaulne force-pushed the 03-25-moves_app_footer branch from d1c9f97 to cff4b8c Compare March 27, 2026 14:12
@Mbeaulne Mbeaulne force-pushed the 03-24-add_new_section_to_the_side_bar branch from d8285d7 to df32b4a Compare March 27, 2026 14:16
Comment on lines +115 to +117
{ label: "About", href: ABOUT_URL },
{ label: "Give feedback", href: GIVE_FEEDBACK_URL },
{ label: "Privacy policy", href: PRIVACY_POLICY_URL },
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be a constant outside of the render function

Comment on lines 119 to 127
<a
href={DOCUMENTATION_URL}
key={label}
href={href}
target="_blank"
rel="noopener noreferrer"
className={navItemClass(false)}
className="px-3 py-1 text-xs text-muted-foreground hover:text-foreground rounded-md hover:bg-accent"
>
<Icon name="BookOpen" size="sm" />
<Text size="sm">Docs</Text>
{label}
</a>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo these should be buttons rather than styled hyperlinks

{/* Bottom utilities */}
<BlockStack gap="1" className="border-t border-border pt-3">
{/* Footer links */}
<div className="flex flex-col gap-0.5 pt-2 mt-1 border-t border-border">
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BlockStack

@Mbeaulne Mbeaulne force-pushed the 03-25-moves_app_footer branch from 28ca9f9 to c889894 Compare April 9, 2026 15:54
@Mbeaulne Mbeaulne force-pushed the 03-24-add_new_section_to_the_side_bar branch 2 times, most recently from 6f05d41 to b321fbe Compare April 9, 2026 16:09
@Mbeaulne Mbeaulne force-pushed the 03-25-moves_app_footer branch from c889894 to 019c1fb Compare April 9, 2026 16:09
@Mbeaulne Mbeaulne force-pushed the 03-24-add_new_section_to_the_side_bar branch from b321fbe to 8620c23 Compare April 9, 2026 16:28
@Mbeaulne Mbeaulne force-pushed the 03-25-moves_app_footer branch 2 times, most recently from 0916fe7 to bea18e9 Compare April 9, 2026 16:56
@Mbeaulne Mbeaulne force-pushed the 03-25-moves_app_footer branch from bea18e9 to d514ad3 Compare April 9, 2026 19:53
@Mbeaulne Mbeaulne force-pushed the 03-24-add_new_section_to_the_side_bar branch 2 times, most recently from a7884a6 to dfc41bc Compare April 9, 2026 20:04
@Mbeaulne Mbeaulne force-pushed the 03-25-moves_app_footer branch 2 times, most recently from 36f9bf0 to 666981c Compare April 9, 2026 20:13
@Mbeaulne Mbeaulne force-pushed the 03-24-add_new_section_to_the_side_bar branch 2 times, most recently from 0c57d9c to f6e5b02 Compare April 10, 2026 19:09
@Mbeaulne Mbeaulne force-pushed the 03-25-moves_app_footer branch 2 times, most recently from 98e74b0 to ec30e52 Compare April 10, 2026 19:31
@Mbeaulne Mbeaulne force-pushed the 03-24-add_new_section_to_the_side_bar branch 2 times, most recently from 7759b79 to df7dead Compare April 10, 2026 19:59
@Mbeaulne Mbeaulne force-pushed the 03-25-moves_app_footer branch from ec30e52 to 92002ac Compare April 10, 2026 19:59
Copy link
Copy Markdown
Collaborator Author

Mbeaulne commented Apr 10, 2026

Merge activity

  • Apr 10, 8:38 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 10, 9:33 PM UTC: Graphite rebased this pull request as part of a merge.
  • Apr 10, 9:36 PM UTC: @Mbeaulne merged this pull request with Graphite.

@Mbeaulne Mbeaulne changed the base branch from 03-24-add_new_section_to_the_side_bar to graphite-base/2010 April 10, 2026 21:29
@Mbeaulne Mbeaulne changed the base branch from graphite-base/2010 to master April 10, 2026 21:32
@Mbeaulne Mbeaulne force-pushed the 03-25-moves_app_footer branch from 92002ac to 39fd83a Compare April 10, 2026 21:33
@Mbeaulne Mbeaulne merged commit e5a90f2 into master Apr 10, 2026
17 checks passed
@Mbeaulne Mbeaulne deleted the 03-25-moves_app_footer branch April 10, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants