Skip to content

update favourite and recent cards#2001

Merged
Mbeaulne merged 1 commit intomasterfrom
03-24-update_favourite_and_recent_cards
Apr 10, 2026
Merged

update favourite and recent cards#2001
Mbeaulne merged 1 commit intomasterfrom
03-24-update_favourite_and_recent_cards

Conversation

@Mbeaulne
Copy link
Copy Markdown
Collaborator

@Mbeaulne Mbeaulne commented Mar 24, 2026

Description

Replaced programmatic navigation with Link components in dashboard favorite and recently viewed cards. Changed the type indicators from simple icon/text combinations to pill-style badges with rounded backgrounds. Updated card styling to use consistent shadow effects and neutral colors instead of type-specific color schemes.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  1. Navigate to the dashboard
  2. Verify that favorite cards are clickable and navigate correctly
  3. Verify that recently viewed cards are clickable and navigate correctly
  4. Test that the remove favorite button works without triggering navigation
  5. Confirm that type pills display correctly for both pipelines and runs
  6. Check that hover effects work properly on the cards

Additional Comments

The Link component provides better accessibility and browser behavior (right-click to open in new tab, etc.) compared to programmatic navigation. The pill-style type indicators provide better visual hierarchy and the unified card styling creates a more consistent interface.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 24, 2026

🎩 To tophat this PR:

You can add the following URL parameter to your browser to tophat this PR:

`?tophat_location=03-24-update_favourite_and_recent_cards/bc09f9b`

@Mbeaulne Mbeaulne force-pushed the 03-24-update_favourite_and_recent_cards branch from 6dcffa7 to 4dabee9 Compare March 27, 2026 12:41
@Mbeaulne Mbeaulne force-pushed the 03-24-updates_revently_viewed branch from 091ad6b to 89f86e1 Compare March 27, 2026 12:41
@Mbeaulne Mbeaulne force-pushed the 03-24-update_favourite_and_recent_cards branch from 4dabee9 to 7c59fd6 Compare March 27, 2026 13:52
@Mbeaulne Mbeaulne force-pushed the 03-24-updates_revently_viewed branch from 89f86e1 to 50aadd0 Compare March 27, 2026 13:52
@Mbeaulne Mbeaulne force-pushed the 03-24-update_favourite_and_recent_cards branch from 7c59fd6 to 6059b23 Compare March 27, 2026 13:58
@Mbeaulne Mbeaulne force-pushed the 03-24-updates_revently_viewed branch 2 times, most recently from 2b7baf9 to 878220c Compare March 27, 2026 14:07
@Mbeaulne Mbeaulne force-pushed the 03-24-update_favourite_and_recent_cards branch 2 times, most recently from 1a4aed7 to dfef4db Compare March 27, 2026 14:12
@Mbeaulne Mbeaulne force-pushed the 03-24-updates_revently_viewed branch from 7982636 to ea60d9f Compare March 27, 2026 14:16
@Mbeaulne Mbeaulne force-pushed the 03-24-update_favourite_and_recent_cards branch from dfef4db to 0ef8ac0 Compare March 27, 2026 14:16
@Mbeaulne Mbeaulne force-pushed the 03-24-update_favourite_and_recent_cards branch from 61f4a27 to 0e9856e Compare April 8, 2026 19:31
@Mbeaulne Mbeaulne force-pushed the 03-24-updates_revently_viewed branch from de4672f to 007401d Compare April 8, 2026 19:31
This was referenced Apr 8, 2026
Comment thread src/routes/Dashboard/DashboardRecentlyViewedView.tsx
@Mbeaulne Mbeaulne force-pushed the 03-24-update_favourite_and_recent_cards branch from 0e9856e to 9e0f474 Compare April 9, 2026 15:54
@Mbeaulne Mbeaulne force-pushed the 03-24-updates_revently_viewed branch 2 times, most recently from 82139f0 to 9fadba0 Compare April 9, 2026 16:09
@Mbeaulne Mbeaulne force-pushed the 03-24-update_favourite_and_recent_cards branch from 9e0f474 to 9533a93 Compare April 9, 2026 16:09
@Mbeaulne Mbeaulne force-pushed the 03-24-updates_revently_viewed branch from 9fadba0 to ad79e4e Compare April 9, 2026 16:28
@Mbeaulne Mbeaulne force-pushed the 03-24-update_favourite_and_recent_cards branch from 9533a93 to 19282ca Compare April 9, 2026 16:28
@Mbeaulne Mbeaulne force-pushed the 03-24-updates_revently_viewed branch from ad79e4e to e4b99d4 Compare April 9, 2026 16:56
@Mbeaulne Mbeaulne force-pushed the 03-24-update_favourite_and_recent_cards branch from 19282ca to 4d44fc9 Compare April 9, 2026 16:56
@Mbeaulne Mbeaulne force-pushed the 03-24-updates_revently_viewed branch from e4b99d4 to d713eaa Compare April 9, 2026 19:53
@Mbeaulne Mbeaulne force-pushed the 03-24-update_favourite_and_recent_cards branch from 4d44fc9 to 001fa3f Compare April 9, 2026 19:53
@Mbeaulne Mbeaulne force-pushed the 03-24-updates_revently_viewed branch from d713eaa to 089810e Compare April 9, 2026 20:04
@Mbeaulne Mbeaulne force-pushed the 03-24-update_favourite_and_recent_cards branch 2 times, most recently from 05819b9 to 3caca22 Compare April 9, 2026 20:13
@Mbeaulne Mbeaulne requested a review from camielvs April 10, 2026 18:37
@Mbeaulne Mbeaulne force-pushed the 03-24-update_favourite_and_recent_cards branch from 3caca22 to 98f838f Compare April 10, 2026 19:09
@Mbeaulne Mbeaulne force-pushed the 03-24-updates_revently_viewed branch from 089810e to 9031ebb Compare April 10, 2026 19:09
Copy link
Copy Markdown
Collaborator Author

Mbeaulne commented Apr 10, 2026

Merge activity

  • Apr 10, 8:38 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 10, 9:19 PM UTC: Graphite rebased this pull request as part of a merge.
  • Apr 10, 9:21 PM UTC: @Mbeaulne merged this pull request with Graphite.

@Mbeaulne Mbeaulne changed the base branch from 03-24-updates_revently_viewed to graphite-base/2001 April 10, 2026 21:16
@Mbeaulne Mbeaulne changed the base branch from graphite-base/2001 to master April 10, 2026 21:18
@Mbeaulne Mbeaulne force-pushed the 03-24-update_favourite_and_recent_cards branch from 98f838f to bc09f9b Compare April 10, 2026 21:19
@Mbeaulne Mbeaulne merged commit 1adf147 into master Apr 10, 2026
17 checks passed
@Mbeaulne Mbeaulne deleted the 03-24-update_favourite_and_recent_cards branch April 10, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants