Skip to content

feat_favorites_homepage_section#1983

Merged
Mbeaulne merged 2 commits intomasterfrom
03-23-feat_favorites_homepage_section
Apr 10, 2026
Merged

feat_favorites_homepage_section#1983
Mbeaulne merged 2 commits intomasterfrom
03-23-feat_favorites_homepage_section

Conversation

@Mbeaulne
Copy link
Copy Markdown
Collaborator

Description

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

Additional Comments

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 23, 2026

🎩 To tophat this PR:

You can add the following URL parameter to your browser to tophat this PR:

`?tophat_location=03-23-feat_favorites_homepage_section/c697d88`

@Mbeaulne
Copy link
Copy Markdown
Collaborator Author

Reviewer note: FavoritesSection.tsx (the chip-based layout introduced here) is deleted in #1996 as part of a design pivot away from chips toward cards. It is briefly re-added verbatim in #1997 and then deleted again in #1998.

You can treat this PR as exploratory UI iteration — the final favorites design lives in DashboardFavoritesView.tsx (#1998+). No need to give deep feedback on the chip layout.

@Mbeaulne Mbeaulne marked this pull request as ready for review March 30, 2026 18:22
@Mbeaulne Mbeaulne requested a review from a team as a code owner March 30, 2026 18:22
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_homepage_section branch from 2622e15 to 557cdac Compare April 1, 2026 17:49
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_toggle_ui branch from db36636 to 0e25eb8 Compare April 1, 2026 17:49
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_homepage_section branch from 3e93860 to 3b5574d Compare April 1, 2026 18:42
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_toggle_ui branch from e8c83af to e1582e5 Compare April 2, 2026 19:19
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_homepage_section branch from 3b5574d to 95b5dcb Compare April 2, 2026 19:19
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_toggle_ui branch from e1582e5 to eff8a54 Compare April 6, 2026 13:12
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_homepage_section branch from 95b5dcb to 097fcf7 Compare April 6, 2026 13:12
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_toggle_ui branch from eff8a54 to e0e961f Compare April 8, 2026 17:25
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_homepage_section branch from 097fcf7 to 8676de7 Compare April 8, 2026 17:25
This was referenced Apr 8, 2026
Comment thread src/components/Home/FavoritesSection/FavoritesSection.tsx Outdated
Comment thread src/components/Home/FavoritesSection/FavoritesSection.tsx Outdated
Comment thread src/components/Home/FavoritesSection/FavoritesSection.tsx Outdated
Comment thread src/components/Home/FavoritesSection/FavoritesSection.tsx Outdated
Comment thread src/components/Home/FavoritesSection/FavoritesSection.tsx Outdated
Comment thread src/components/Home/FavoritesSection/FavoritesSection.tsx Outdated
Comment thread src/components/Home/FavoritesSection/FavoritesSection.tsx Outdated
Comment thread src/components/Home/FavoritesSection/FavoritesSection.tsx Outdated
Comment thread src/components/Home/FavoritesSection/FavoritesSection.tsx Outdated
Copy link
Copy Markdown
Collaborator

camielvs commented Apr 9, 2026

You can treat this PR as exploratory UI iteration — the final favorites design lives in DashboardFavoritesView.tsx (#1998+). No need to give deep feedback on the chip layout.

Hah I should have read this first.

Curious why not just remove this PR from the stack?

Copy link
Copy Markdown
Collaborator

@camielvs camielvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on your comment my understanding is that I should just ignore this PR and let it be merged as part of the stack.

The comments may still be useful though, for other areas

@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_toggle_ui branch from e0e961f to d87655e Compare April 9, 2026 15:54
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_homepage_section branch from 8676de7 to 1aac08c Compare April 9, 2026 15:54
Copy link
Copy Markdown
Collaborator Author

Mbeaulne commented Apr 10, 2026

Merge activity

  • Apr 10, 8:38 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 10, 8:50 PM UTC: Graphite rebased this pull request as part of a merge.
  • Apr 10, 8:52 PM UTC: @Mbeaulne merged this pull request with Graphite.

@Mbeaulne Mbeaulne changed the base branch from 03-23-feat_favorites_toggle_ui to graphite-base/1983 April 10, 2026 20:46
@Mbeaulne Mbeaulne changed the base branch from graphite-base/1983 to master April 10, 2026 20:49
Mbeaulne and others added 2 commits April 10, 2026 20:50
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_homepage_section branch from 8e8aa39 to c697d88 Compare April 10, 2026 20:50
@Mbeaulne Mbeaulne merged commit ae09c9c into master Apr 10, 2026
17 checks passed
@Mbeaulne Mbeaulne deleted the 03-23-feat_favorites_homepage_section branch April 10, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants