Skip to content

feat_favorites_toggle_ui#1982

Merged
Mbeaulne merged 1 commit intomasterfrom
03-23-feat_favorites_toggle_ui
Apr 10, 2026
Merged

feat_favorites_toggle_ui#1982
Mbeaulne merged 1 commit intomasterfrom
03-23-feat_favorites_toggle_ui

Conversation

@Mbeaulne
Copy link
Copy Markdown
Collaborator

@Mbeaulne Mbeaulne commented Mar 23, 2026

Description

Added favorite functionality to pipelines and runs throughout the application. Users can now mark pipelines and runs as favorites using a star icon toggle button. The FavoriteToggle component has been integrated into:

  • Pipeline details context panel
  • Pipeline rows in the home section
  • Run rows in the home section
  • Pipeline run toolbar

The toggle button displays as a filled star when favorited and an outline when not favorited, with appropriate hover states and click handling to prevent event propagation.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  1. Navigate to the home page and verify star icons appear next to pipelines and runs
  2. Click the star icon to toggle favorite status - it should fill/unfill appropriately
  3. Open a pipeline in the editor and verify the favorite toggle appears in the context panel actions
  4. Open a pipeline run and verify the favorite toggle appears in the run toolbar
  5. Verify clicking the favorite toggle doesn't interfere with other row/button interactions

Additional Comments

The FavoriteToggle component uses the useFavorites hook to manage favorite state and integrates with the existing UI patterns. The component prevents click event propagation to avoid conflicts with row selection or navigation.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 23, 2026

🎩 To tophat this PR:

You can add the following URL parameter to your browser to tophat this PR:

`?tophat_location=03-23-feat_favorites_toggle_ui/d2e47c0`

@Mbeaulne
Copy link
Copy Markdown
Collaborator Author

Reviewer note: FavoriteToggle and the star icon integrations in PipelineRow, RunRow, PipelineDetails, and RunToolbar are stable and survive the full stack unchanged. Safe to review normally.

@Mbeaulne Mbeaulne marked this pull request as ready for review March 30, 2026 18:22
@Mbeaulne Mbeaulne requested a review from a team as a code owner March 30, 2026 18:22
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_toggle_ui branch 3 times, most recently from 46059ca to e8c83af Compare April 1, 2026 18:37
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_infrastructure branch from 03b33a8 to e2e7cf5 Compare April 2, 2026 19:19
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_toggle_ui branch 2 times, most recently from e1582e5 to eff8a54 Compare April 6, 2026 13:12
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_infrastructure branch from e2e7cf5 to eb481ef Compare April 6, 2026 13:12
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_toggle_ui branch from eff8a54 to e0e961f Compare April 8, 2026 17:25
This was referenced Apr 8, 2026
Comment thread src/components/shared/FavoriteToggle.tsx Outdated
Comment thread src/components/Home/PipelineSection/PipelineRow.tsx
Copy link
Copy Markdown
Collaborator

@camielvs camielvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Tasks we have the "Favourite" star up by the title

image.png

imo we should be consistent. It feels a little off being next to the larger buttons and one-off actions

image.png

and I especially don't love it up here in the toolbar 🫠
image.png

@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_toggle_ui branch from e0e961f to d87655e Compare April 9, 2026 15:54
@Mbeaulne Mbeaulne requested a review from camielvs April 10, 2026 15:32
Copy link
Copy Markdown
Collaborator Author

I'll fix these later but I dont htink its worth blocking

Copy link
Copy Markdown
Collaborator Author

Mbeaulne commented Apr 10, 2026

Merge activity

  • Apr 10, 8:38 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 10, 8:46 PM UTC: Graphite rebased this pull request as part of a merge.
  • Apr 10, 8:49 PM UTC: @Mbeaulne merged this pull request with Graphite.

@Mbeaulne Mbeaulne changed the base branch from 03-23-feat_favorites_infrastructure to graphite-base/1982 April 10, 2026 20:42
@Mbeaulne Mbeaulne changed the base branch from graphite-base/1982 to master April 10, 2026 20:45
@Mbeaulne Mbeaulne force-pushed the 03-23-feat_favorites_toggle_ui branch from d87655e to d2e47c0 Compare April 10, 2026 20:46
@Mbeaulne Mbeaulne merged commit 9be37dc into master Apr 10, 2026
17 checks passed
@Mbeaulne Mbeaulne deleted the 03-23-feat_favorites_toggle_ui branch April 10, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants