chore: update vertexAiCompiler#1773
Draft
maxy-shpfy wants to merge 1 commit intomasterfrom
Draft
Conversation
This was referenced Feb 9, 2026
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4 tasks
a572bc3 to
c11bc3e
Compare
f427f0b to
8bfc272
Compare
c11bc3e to
0c03418
Compare
8bfc272 to
038bbb0
Compare
0c03418 to
8dcc778
Compare
038bbb0 to
4c10b14
Compare
84fbf40 to
8dc90b6
Compare
4c10b14 to
7fe083d
Compare
8dc90b6 to
da46fd3
Compare
7fe083d to
9548f61
Compare
maxy-shpfy
commented
Feb 18, 2026
| }, | ||
| }; | ||
| return result; | ||
| } else if (isSecretArgument(taskArgument)) { |
Collaborator
Author
There was a problem hiding this comment.
@Ark-kun since you're an expert in vertexAI - should we pass "Secret" into it? or throw an error as "unsupported"?
9548f61 to
65b9fdc
Compare
4313cef to
d9b56ae
Compare
65b9fdc to
516b447
Compare
d9b56ae to
dc13cbb
Compare
516b447 to
4da2463
Compare
dc13cbb to
f014a9b
Compare
4da2463 to
f22f4f9
Compare
f014a9b to
7d0d88d
Compare
47c783c to
7718112
Compare
7d0d88d to
5248fe1
Compare
7718112 to
cf6c466
Compare
5248fe1 to
5a3dd04
Compare
cf6c466 to
c2a05c4
Compare
8ca4fcb to
cd2703a
Compare
c2a05c4 to
1e8d99c
Compare
cd2703a to
2a52424
Compare
1b135f8 to
559c17e
Compare
2a52424 to
635b88b
Compare
559c17e to
7c01808
Compare
635b88b to
b20135f
Compare
7c01808 to
7fe796d
Compare
b20135f to
ae4e908
Compare
7fe796d to
f7b6539
Compare
ae4e908 to
6ca71ef
Compare
71d9b08 to
e6194e8
Compare
6ca71ef to
a884906
Compare
a884906 to
0f117d8
Compare
e6194e8 to
df5e50b
Compare
0f117d8 to
dbc692e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Added error handling for secret arguments in Vertex AI compilation. The changes throw specific error messages when secret arguments are encountered in both parameter and artifact argument specifications, as they are not supported in Vertex AI.
Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Test by attempting to compile a component with secret arguments for Vertex AI and verify that the appropriate error message is displayed.
Additional Comments
This change improves error handling by providing clear error messages when users attempt to use secret arguments with Vertex AI, which doesn't support this feature.