feat: use API as secrets storage#1771
Merged
maxy-shpfy merged 1 commit intomasterfrom Feb 19, 2026
Merged
Conversation
This was referenced Feb 9, 2026
Collaborator
Author
This was referenced Feb 9, 2026
eaea086 to
9e2971d
Compare
569e86c to
cd647b8
Compare
4af80de to
ba35d0e
Compare
cd647b8 to
b3b5c86
Compare
ba35d0e to
4c05923
Compare
b3b5c86 to
0889f6e
Compare
4c05923 to
f524ce5
Compare
0889f6e to
7c9edf4
Compare
f524ce5 to
aae28ba
Compare
7c9edf4 to
1534ee0
Compare
aae28ba to
522a970
Compare
1534ee0 to
1a51515
Compare
522a970 to
abd5dd6
Compare
1a51515 to
6cd67a9
Compare
abd5dd6 to
dc69185
Compare
6cd67a9 to
3530186
Compare
camielvs
reviewed
Feb 18, 2026
camielvs
reviewed
Feb 18, 2026
Collaborator
|
I guess it's an issue without our Here I am trying to open the secrets dialog with an outdated backend. i.e. the dialog cannot open because fetching the secrets list fails. You can get similar behaviour with no backend configured. - which raises the question: should we at least be able to open the dialog (and populate it with a message about missing backend) when there's no backend available? |
d783374 to
23d41ad
Compare
Collaborator
Author
|
>when there's no backend available? |
e8cccf1 to
7ee8e8b
Compare
1566480 to
9d6cec2
Compare
7ee8e8b to
d65e341
Compare
9d6cec2 to
c673148
Compare
camielvs
reviewed
Feb 18, 2026
Collaborator
camielvs
left a comment
There was a problem hiding this comment.
Add / Edit / Delete works great
camielvs
approved these changes
Feb 18, 2026
c673148 to
4269b09
Compare
3af39ce to
fa1feb3
Compare
7dd5cef to
4dec3cc
Compare
fa1feb3 to
c5b514b
Compare
4dec3cc to
501671d
Compare
c5b514b to
238f88a
Compare
9db2154 to
850ad9f
Compare
238f88a to
5eb34e0
Compare
5eb34e0 to
fca7f91
Compare
850ad9f to
199c70c
Compare
fca7f91 to
2e2f9b6
Compare
Collaborator
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Refactored the secrets management system to use the API endpoints instead of the in-memory mock storage. This change connects the frontend secrets management UI to the backend API by:
getSecrets→fetchSecretsListaddSecret,updateSecret, andremoveSecretto use API endpointsvalueproperty optional, as the API doesn't return secret values when listing secretsSecretsQueryKeysfrom secretsStorage.ts to types.ts for better organizationType of Change
Checklist
Screenshots
Secrets real usage.mov (uploaded via Graphite)
Test Instructions