Skip to content

feat: use API as secrets storage#1771

Merged
maxy-shpfy merged 1 commit intomasterfrom
02-09-feat_use_api_as_secrets_storage
Feb 19, 2026
Merged

feat: use API as secrets storage#1771
maxy-shpfy merged 1 commit intomasterfrom
02-09-feat_use_api_as_secrets_storage

Conversation

@maxy-shpfy
Copy link
Copy Markdown
Collaborator

@maxy-shpfy maxy-shpfy commented Feb 9, 2026

Description

Refactored the secrets management system to use the API endpoints instead of the in-memory mock storage. This change connects the frontend secrets management UI to the backend API by:

  1. Replacing mock functions with actual API calls:
    • getSecretsfetchSecretsList
    • Updated addSecret, updateSecret, and removeSecret to use API endpoints
  2. Modified the Secret type to make the value property optional, as the API doesn't return secret values when listing secrets
  3. Moved the SecretsQueryKeys from secretsStorage.ts to types.ts for better organization

Type of Change

  • Improvement
  • Refactor

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots

Secrets real usage.mov (uploaded via Graphite)

Test Instructions

  1. Open the Secrets Management dialog
  2. Create a new secret
  3. Update an existing secret
  4. Delete a secret
  5. Verify all operations work correctly with the backend API

@maxy-shpfy maxy-shpfy force-pushed the 02-09-chore_regenerate_api_based_on_secrets_api_backend branch from eaea086 to 9e2971d Compare February 9, 2026 21:04
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch 2 times, most recently from 569e86c to cd647b8 Compare February 9, 2026 21:07
@maxy-shpfy maxy-shpfy force-pushed the 02-09-chore_regenerate_api_based_on_secrets_api_backend branch 2 times, most recently from 4af80de to ba35d0e Compare February 9, 2026 21:28
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch from cd647b8 to b3b5c86 Compare February 9, 2026 21:28
@maxy-shpfy maxy-shpfy force-pushed the 02-09-chore_regenerate_api_based_on_secrets_api_backend branch from ba35d0e to 4c05923 Compare February 9, 2026 21:32
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch from b3b5c86 to 0889f6e Compare February 9, 2026 21:32
@maxy-shpfy maxy-shpfy force-pushed the 02-09-chore_regenerate_api_based_on_secrets_api_backend branch from 4c05923 to f524ce5 Compare February 9, 2026 22:03
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch from 0889f6e to 7c9edf4 Compare February 9, 2026 22:03
@maxy-shpfy maxy-shpfy force-pushed the 02-09-chore_regenerate_api_based_on_secrets_api_backend branch from f524ce5 to aae28ba Compare February 18, 2026 01:30
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch from 7c9edf4 to 1534ee0 Compare February 18, 2026 01:30
@maxy-shpfy maxy-shpfy marked this pull request as ready for review February 18, 2026 01:32
@maxy-shpfy maxy-shpfy requested a review from a team as a code owner February 18, 2026 01:32
@maxy-shpfy maxy-shpfy force-pushed the 02-09-chore_regenerate_api_based_on_secrets_api_backend branch from aae28ba to 522a970 Compare February 18, 2026 19:11
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch from 1534ee0 to 1a51515 Compare February 18, 2026 19:11
@maxy-shpfy maxy-shpfy force-pushed the 02-09-chore_regenerate_api_based_on_secrets_api_backend branch from 522a970 to abd5dd6 Compare February 18, 2026 19:36
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch from 1a51515 to 6cd67a9 Compare February 18, 2026 19:36
@maxy-shpfy maxy-shpfy force-pushed the 02-09-chore_regenerate_api_based_on_secrets_api_backend branch from abd5dd6 to dc69185 Compare February 18, 2026 19:46
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch from 6cd67a9 to 3530186 Compare February 18, 2026 19:46
Comment thread src/components/PipelineRun/components/RerunPipelineButton.tsx
Comment thread src/components/shared/SecretsManagement/secretsStorage.ts Outdated
Copy link
Copy Markdown
Collaborator

I guess it's an issue without our AppMenu and not the secrets work specifically, but if a menu button is loaded/failed things get a bit wonky

image.png

image.png

Here I am trying to open the secrets dialog with an outdated backend. i.e. the dialog cannot open because fetching the secrets list fails. You can get similar behaviour with no backend configured. - which raises the question: should we at least be able to open the dialog (and populate it with a message about missing backend) when there's no backend available?

@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch from d783374 to 23d41ad Compare February 18, 2026 20:27
Copy link
Copy Markdown
Collaborator Author

>when there's no backend available?
I can take this as a separate PR

@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch 2 times, most recently from e8cccf1 to 7ee8e8b Compare February 18, 2026 20:59
@maxy-shpfy maxy-shpfy force-pushed the 02-09-chore_regenerate_api_based_on_secrets_api_backend branch from 1566480 to 9d6cec2 Compare February 18, 2026 20:59
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch from 7ee8e8b to d65e341 Compare February 18, 2026 21:02
@maxy-shpfy maxy-shpfy force-pushed the 02-09-chore_regenerate_api_based_on_secrets_api_backend branch from 9d6cec2 to c673148 Compare February 18, 2026 21:02
@maxy-shpfy maxy-shpfy requested a review from camielvs February 18, 2026 21:11
Copy link
Copy Markdown
Collaborator

@camielvs camielvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add / Edit / Delete works great

@maxy-shpfy maxy-shpfy force-pushed the 02-09-chore_regenerate_api_based_on_secrets_api_backend branch from c673148 to 4269b09 Compare February 19, 2026 01:56
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch 2 times, most recently from 3af39ce to fa1feb3 Compare February 19, 2026 02:50
@maxy-shpfy maxy-shpfy force-pushed the 02-09-chore_regenerate_api_based_on_secrets_api_backend branch 2 times, most recently from 7dd5cef to 4dec3cc Compare February 19, 2026 02:53
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch from fa1feb3 to c5b514b Compare February 19, 2026 02:54
@maxy-shpfy maxy-shpfy force-pushed the 02-09-chore_regenerate_api_based_on_secrets_api_backend branch from 4dec3cc to 501671d Compare February 19, 2026 03:10
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch from c5b514b to 238f88a Compare February 19, 2026 03:11
@maxy-shpfy maxy-shpfy force-pushed the 02-09-chore_regenerate_api_based_on_secrets_api_backend branch 2 times, most recently from 9db2154 to 850ad9f Compare February 19, 2026 03:38
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch from 238f88a to 5eb34e0 Compare February 19, 2026 03:39
@maxy-shpfy maxy-shpfy changed the base branch from 02-09-chore_regenerate_api_based_on_secrets_api_backend to graphite-base/1771 February 19, 2026 03:51
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch from 5eb34e0 to fca7f91 Compare February 19, 2026 03:52
@graphite-app graphite-app Bot changed the base branch from graphite-base/1771 to master February 19, 2026 03:52
@maxy-shpfy maxy-shpfy force-pushed the 02-09-feat_use_api_as_secrets_storage branch from fca7f91 to 2e2f9b6 Compare February 19, 2026 03:52
Copy link
Copy Markdown
Collaborator Author

maxy-shpfy commented Feb 19, 2026

Merge activity

  • Feb 19, 3:54 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 19, 3:55 AM UTC: @maxy-shpfy merged this pull request with Graphite.

@maxy-shpfy maxy-shpfy merged commit d978d10 into master Feb 19, 2026
7 of 8 checks passed
@maxy-shpfy maxy-shpfy deleted the 02-09-feat_use_api_as_secrets_storage branch February 19, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants