Skip to content

feat: use secrets in canvas tasks and arguments editor#1766

Merged
maxy-shpfy merged 1 commit intomasterfrom
02-06-feat_use_secrets_in_canvas_tasks_and_arguments_editor
Feb 19, 2026
Merged

feat: use secrets in canvas tasks and arguments editor#1766
maxy-shpfy merged 1 commit intomasterfrom
02-06-feat_use_secrets_in_canvas_tasks_and_arguments_editor

Conversation

@maxy-shpfy
Copy link
Copy Markdown
Collaborator

@maxy-shpfy maxy-shpfy commented Feb 6, 2026 •
edited
Loading

Description

Added support for secret arguments in the task node UI. Users can now select secrets from a dialog and use them as argument values. Secret arguments are displayed with a lock icon and special formatting to distinguish them from regular values.

Type of Change

  • New feature
  • Improvement

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Secret in Arguments and Canvas.mov (uploaded via Graphite)

Test Instructions

  1. Enable the "secrets" feature flag
  2. Open a task node's arguments editor
  3. Click the lock icon to select a secret
  4. Verify the secret is displayed correctly in both the editor and node UI
  5. Test clearing a secret and reverting to a regular value

Additional Comments

This implementation includes:

  • A new SecretArgumentInput component for displaying selected secrets
  • Integration with the SelectSecretDialog for choosing secrets
  • Visual indicators (lock icon, amber text) for secret values
  • Proper handling of secret values in the node UI

@maxy-shpfy Graphite App
Copy link
Copy Markdown
Collaborator Author

maxy-shpfy commented Feb 6, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Feb 6, 2026
Merged
Merged
@maxy-shpfy maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_canvas_tasks_and_arguments_editor branch from f8de3f0 to ff72e68 Compare February 9, 2026 20:54
This was referenced Feb 9, 2026
Merged
Merged
Merged
Draft
@maxy-shpfy maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_canvas_tasks_and_arguments_editor branch from ff72e68 to 76e1ba3 Compare February 9, 2026 21:04
@maxy-shpfy maxy-shpfy force-pushed the 02-05-feat_secrets_management_ui branch 2 times, most recently from 303639b to d6d2dda Compare February 9, 2026 21:07
@maxy-shpfy maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_canvas_tasks_and_arguments_editor branch from 76e1ba3 to ffe4c37 Compare February 9, 2026 21:07
@maxy-shpfy maxy-shpfy force-pushed the 02-05-feat_secrets_management_ui branch from d6d2dda to cf6fc56 Compare February 9, 2026 21:28
@maxy-shpfy maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_canvas_tasks_and_arguments_editor branch from ffe4c37 to 8de520a Compare February 9, 2026 21:28
@maxy-shpfy maxy-shpfy force-pushed the 02-05-feat_secrets_management_ui branch from cf6fc56 to e8338b5 Compare February 9, 2026 21:32
@maxy-shpfy maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_canvas_tasks_and_arguments_editor branch from 8de520a to a166e29 Compare February 9, 2026 21:32
@maxy-shpfy maxy-shpfy force-pushed the 02-05-feat_secrets_management_ui branch from e8338b5 to ca5ca10 Compare February 9, 2026 22:03
@maxy-shpfy maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_canvas_tasks_and_arguments_editor branch from a166e29 to 211cc35 Compare February 9, 2026 22:03
@maxy-shpfy maxy-shpfy force-pushed the 02-05-feat_secrets_management_ui branch from ca5ca10 to 9de690a Compare February 18, 2026 01:30
@maxy-shpfy maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_canvas_tasks_and_arguments_editor branch from 211cc35 to fd03b48 Compare February 18, 2026 01:30
@maxy-shpfy maxy-shpfy marked this pull request as ready for review February 18, 2026 01:32
@maxy-shpfy maxy-shpfy requested a review from a team as a code owner February 18, 2026 01:32
@maxy-shpfy maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_canvas_tasks_and_arguments_editor branch from fd03b48 to b89e896 Compare February 18, 2026 19:11
@maxy-shpfy maxy-shpfy force-pushed the 02-05-feat_secrets_management_ui branch from 9de690a to 0bf5e60 Compare February 18, 2026 19:11
Mbeaulne
Mbeaulne reviewed Feb 18, 2026
View reviewed changes
Comment thread src/components/shared/ReactFlow/FlowCanvas/TaskNode/ArgumentsEditor/ArgumentInputField.tsx
Comment thread src/components/shared/ReactFlow/FlowCanvas/TaskNode/ArgumentsEditor/ArgumentInputField.tsx
Comment thread src/components/shared/ReactFlow/FlowCanvas/TaskNode/ArgumentsEditor/ArgumentInputField.tsx
Mbeaulne
Mbeaulne reviewed Feb 18, 2026
View reviewed changes
Comment thread src/components/shared/ReactFlow/FlowCanvas/TaskNode/ArgumentsEditor/utils.ts
@maxy-shpfy maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_canvas_tasks_and_arguments_editor branch from b89e896 to 27f3a22 Compare February 18, 2026 19:36
@maxy-shpfy maxy-shpfy force-pushed the 02-05-feat_secrets_management_ui branch from 0bf5e60 to dca099d Compare February 18, 2026 19:46
@maxy-shpfy maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_canvas_tasks_and_arguments_editor branch from 27f3a22 to cd0cdde Compare February 18, 2026 19:46
camielvs
camielvs reviewed Feb 18, 2026
View reviewed changes
Comment thread src/components/shared/ReactFlow/FlowCanvas/TaskNode/TaskNodeCard/Handles.tsx
<Icon
name="Lock"
size="xs"
className="text-amber-600 shrink-0"
Copy link
Copy Markdown
Collaborator

@camielvs camielvs Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes me wonder if we should set a tailwind css class for text-secret, bg-secret etc

camielvs
camielvs approved these changes Feb 18, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@camielvs camielvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits but otherwise LGTM

@camielvs Graphite App
Copy link
Copy Markdown
Collaborator

camielvs commented Feb 18, 2026 •
edited
Loading

Actually, one question which is probably applicable later in the stack but I'm going to ask it here: if I set a task argument to be a secret then clone the pipeline, what happens? Similarly, if I run the pipeline and someone clones, what happens to the secret?

@maxy-shpfy maxy-shpfy force-pushed the 02-05-feat_secrets_management_ui branch from dca099d to a448d6e Compare February 18, 2026 20:59
@maxy-shpfy maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_canvas_tasks_and_arguments_editor branch 2 times, most recently from 0ea1669 to dd2207d Compare February 18, 2026 21:02
@maxy-shpfy maxy-shpfy force-pushed the 02-05-feat_secrets_management_ui branch 2 times, most recently from 3e47629 to a348073 Compare February 19, 2026 01:56
@maxy-shpfy maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_canvas_tasks_and_arguments_editor branch from dd2207d to a213ecb Compare February 19, 2026 01:56
@maxy-shpfy maxy-shpfy changed the base branch from 02-05-feat_secrets_management_ui to graphite-base/1766 February 19, 2026 02:51
@maxy-shpfy maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_canvas_tasks_and_arguments_editor branch from a213ecb to 6918412 Compare February 19, 2026 02:52
@graphite-app graphite-app Bot changed the base branch from graphite-base/1766 to master February 19, 2026 02:53
@maxy-shpfy maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_canvas_tasks_and_arguments_editor branch from 6918412 to 963e0c9 Compare February 19, 2026 02:53
@maxy-shpfy Graphite App
Copy link
Copy Markdown
Collaborator Author

maxy-shpfy commented Feb 19, 2026

^ cloning secrets into "inputs" is not possible due to Spec Schema limitations of inputs. Secret used as arguments in tasks- will stay as is. Run will fail if no same secret available in user's vault

@maxy-shpfy Graphite App
Copy link
Copy Markdown
Collaborator Author

maxy-shpfy commented Feb 19, 2026 •
edited
Loading

Merge activity

  • Feb 19, 3:09 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 19, 3:10 AM UTC: @maxy-shpfy merged this pull request with Graphite.

@maxy-shpfy maxy-shpfy merged commit 1f48e66 into master Feb 19, 2026
7 of 8 checks passed
@maxy-shpfy maxy-shpfy deleted the 02-06-feat_use_secrets_in_canvas_tasks_and_arguments_editor branch February 19, 2026 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mbeaulne Mbeaulne Mbeaulne left review comments

@camielvs camielvs camielvs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maxy-shpfy @camielvs @Mbeaulne