feat: secrets management ui#1765
Merged
maxy-shpfy merged 1 commit intomasterfrom Feb 19, 2026
Merged
Conversation
Collaborator
Author
This was referenced Feb 6, 2026
maxy-shpfy
force-pushed
the
02-05-feat_secrets_management_ui
branch
5 times, most recently
from
e8338b5 to
ca5ca10
Compare
maxy-shpfy
force-pushed
the
02-05-feat_secrets_management_ui
branch
from
ca5ca10 to
9de690a
Compare
maxy-shpfy
commented
Feb 18, 2026
| @@ -0,0 +1,120 @@ | |||
| import type { Secret } from "./types"; | |||
Collaborator
Author
There was a problem hiding this comment.
This file in this PR is a MOCK, so just ignore it
camielvs
reviewed
Feb 18, 2026
camielvs
reviewed
Feb 18, 2026
camielvs
reviewed
Feb 18, 2026
Mbeaulne
reviewed
Feb 18, 2026
camielvs
reviewed
Feb 18, 2026
maxy-shpfy
force-pushed
the
02-05-feat_secrets_management_ui
branch
from
9de690a to
0bf5e60
Compare
camielvs
reviewed
Feb 18, 2026
camielvs
approved these changes
Feb 18, 2026
Collaborator
camielvs
left a comment
camielvs
left a comment
There was a problem hiding this comment.
Looks/works great. My only comment would be to question if we need a toast for each of the add/edit/delete actions. I feel there's sufficient visual feedback within the dialog to know these actions have succeeded so the toast may not be adding much value. Thoughts?
maxy-shpfy
force-pushed
the
02-05-feat_secrets_management_ui
branch
3 times, most recently
from
a448d6e to
3e47629
Compare
maxy-shpfy
force-pushed
the
02-05-feat_secrets_management_ui
branch
from
3e47629 to
a348073
Compare
Collaborator
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a secrets management system that allows users to securely store and use sensitive information like API keys in pipelines. The implementation includes:
Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Secrets management UI demo.mov (uploaded via Graphite)
Test Instructions
Additional Comments
The current implementation uses an in-memory storage layer with simulated async behavior. This will be replaced with a proper API integration in a future PR.