feat: use secrets in submit with arguments dialog by maxy-shpfy · Pull Request #1767 · TangleML/tangle-ui

maxy-shpfy · 2026-02-06T23:43:46Z

Description

Added support for SecretArguments in pipeline rerun functionality. This enhancement allows users to securely pass secret values when rerunning pipelines by integrating with the existing secrets management system. The implementation includes UI components for selecting secrets and proper handling of secret arguments throughout the pipeline submission process.

Type of Change

New feature
Improvement

Checklist

I have tested this does not break current pipelines / runs functionality
I have tested the changes on staging

Screenshots

Screen Recording 2026-02-17 at 4.51.13 PM.mov (uploaded via Graphite)

Test Instructions

Enable the "secrets" feature flag
Create a pipeline with parameters
Run the pipeline
Attempt to rerun the pipeline
Verify that you can select secrets for parameters
Confirm that the pipeline runs successfully with the secret values

Additional Comments

This change properly handles SecretArgument types in the pipeline rerun flow, fixing type issues with the API and ensuring secrets are preserved during resubmission. The UI now shows a lock icon for secret values and provides an option to select secrets for parameters.

maxy-shpfy · 2026-02-06T23:44:03Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

Mbeaulne · 2026-02-18T19:19:24Z

            ),
          ),
-          taskArguments: executionData?.rootDetails?.task_spec.arguments,
+          // The generated API types don't include SecretArgument but the backend supports it


can we re-generate the types? npm run generate-api I believe

yeah, that's done in a later PRs - this was created before backend was ready.

But in general it is a broader problem that we have two sets of types to describe the same thing - ComponentSpec one from generated api, one manually written

Agree with this ^ Wish we had a singular automatic solution for a type interface when dealing with the api/backend

We can set this as agenda item for Frontend Sync

camielvs · 2026-02-18T20:08:27Z

And second question: any reason to implement the ability to set a secret argument for an input node on the node itself and not just at runtime?

(i.e. same as secrets for task arguments, but for input nodes instead)

maxy-shpfy · 2026-02-18T20:29:08Z

@camielvs
> any reason to implement the ability to set a secret argument for an input node on the node itself and not just at runtime?

Yes, Secret can be set only for Argument. And Arguments in our case are applicable only when submitting the ComponentSpec as a TaskSpec. So there is no way to set Secret directly onto the input - it simply is not supported by the spec and backend.

maxy-shpfy · 2026-02-18T20:31:03Z

@camielvs
> How will it work with the "copy from recent runs" feature?

It will not be copied. So at this moment secrets need to be set manually each time. I will explore this in a follow up PR

camielvs · 2026-02-18T20:42:04Z

it simply is not supported by the spec

How are task arguments achieving this in a way that would be different to input nodes? I wouldn't be surprised if this is something users ask for. Maybe it would be mitigated if we make "Submit run with arguments" the default behaviour for the submit button.

It will not be copied. So at this moment secrets need to be set manually each time. I will explore this in a follow up PR

That's fine. I tried this in #1771 and nothing happened except a "success" toast appearing. I would recommend removing the toast if nothing actually gets updated.

maxy-shpfy · 2026-02-18T20:46:20Z

>I would recommend removing the toast if nothing actually gets updated.
I was thinking about this, but since it's hard to catch by eye if smth was actually updated from the values standpoint, I decided to keep toast as an action feedback - so user knows action was successful even without visible result (e.g. values are the same)

camielvs · 2026-02-18T20:50:41Z

Maybe a different message/colour will suffice? e.g. "No arguments to copy" or something like that.

maxy-shpfy · 2026-02-18T21:03:00Z

>Maybe a different message/colour will suffice? e.g. "No arguments to copy" or something like that.
I can take that into separate PR - since it is not in scope of current one.

camielvs

LGTM

maxy-shpfy · 2026-02-19T03:37:13Z

Merge activity

Feb 19, 3:37 AM UTC: A user started a stack merge that includes this pull request via Graphite.
Feb 19, 3:37 AM UTC: @maxy-shpfy merged this pull request with Graphite.

maxy-shpfy mentioned this pull request Feb 6, 2026

feat: secrets management ui #1765

Merged

4 tasks

maxy-shpfy mentioned this pull request Feb 6, 2026

feat: use secrets in canvas tasks and arguments editor #1766

Merged

4 tasks

maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_canvas_tasks_and_arguments_editor branch from f8de3f0 to ff72e68 Compare February 9, 2026 20:54

maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_submit_with_arguments_dialog branch from c717675 to b341078 Compare February 9, 2026 20:55

This was referenced Feb 9, 2026

chore: regenerate api based on secrets api backend #1770

Merged

feat: use API as secrets storage #1771

Merged

feat: display secrets in pipeline run view #1772

Merged

chore: update vertexAiCompiler #1773

Draft

maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_canvas_tasks_and_arguments_editor branch from ff72e68 to 76e1ba3 Compare February 9, 2026 21:03

maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_submit_with_arguments_dialog branch 2 times, most recently from a6f7d6e to dea5ac6 Compare February 9, 2026 21:07

maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_canvas_tasks_and_arguments_editor branch 2 times, most recently from ffe4c37 to 8de520a Compare February 9, 2026 21:28

maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_submit_with_arguments_dialog branch from dea5ac6 to 8834c6c Compare February 9, 2026 21:28

maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_canvas_tasks_and_arguments_editor branch from 8de520a to a166e29 Compare February 9, 2026 21:32

maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_submit_with_arguments_dialog branch 2 times, most recently from 764e981 to bf0f4c9 Compare February 9, 2026 22:03

maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_canvas_tasks_and_arguments_editor branch from a166e29 to 211cc35 Compare February 9, 2026 22:03

maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_canvas_tasks_and_arguments_editor branch from 211cc35 to fd03b48 Compare February 18, 2026 01:30

maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_submit_with_arguments_dialog branch from bf0f4c9 to 07cdf48 Compare February 18, 2026 01:30

maxy-shpfy marked this pull request as ready for review February 18, 2026 01:32

maxy-shpfy requested a review from a team as a code owner February 18, 2026 01:32

maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_canvas_tasks_and_arguments_editor branch from fd03b48 to b89e896 Compare February 18, 2026 19:11

maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_submit_with_arguments_dialog branch from 07cdf48 to 76e0840 Compare February 18, 2026 19:11

Mbeaulne reviewed Feb 18, 2026

View reviewed changes

maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_submit_with_arguments_dialog branch from 76e0840 to 95d86dc Compare February 18, 2026 19:36

maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_canvas_tasks_and_arguments_editor branch 2 times, most recently from 27f3a22 to cd0cdde Compare February 18, 2026 19:46

maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_submit_with_arguments_dialog branch from 95d86dc to 23a6f7b Compare February 18, 2026 19:46

maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_submit_with_arguments_dialog branch 2 times, most recently from ce8e281 to e4936a3 Compare February 18, 2026 20:27

camielvs reviewed Feb 18, 2026

View reviewed changes

Comment thread src/components/shared/ReactFlow/FlowCanvas/TaskNode/ArgumentsEditor/SecretArgumentInput.tsx

maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_submit_with_arguments_dialog branch from e4936a3 to b23b20e Compare February 18, 2026 20:59

maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_canvas_tasks_and_arguments_editor branch from 0ea1669 to dd2207d Compare February 18, 2026 21:02

maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_submit_with_arguments_dialog branch from b23b20e to aa2a04f Compare February 18, 2026 21:02

maxy-shpfy requested a review from camielvs February 18, 2026 21:11

camielvs approved these changes Feb 18, 2026

View reviewed changes

maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_canvas_tasks_and_arguments_editor branch from dd2207d to a213ecb Compare February 19, 2026 01:56

maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_submit_with_arguments_dialog branch 2 times, most recently from 6addd92 to a6041e7 Compare February 19, 2026 02:50

maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_canvas_tasks_and_arguments_editor branch 2 times, most recently from 6918412 to 963e0c9 Compare February 19, 2026 02:53

maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_submit_with_arguments_dialog branch from a6041e7 to 5e51121 Compare February 19, 2026 02:53

maxy-shpfy changed the base branch from 02-06-feat_use_secrets_in_canvas_tasks_and_arguments_editor to graphite-base/1767 February 19, 2026 03:10

maxy-shpfy force-pushed the graphite-base/1767 branch from 963e0c9 to 1f48e66 Compare February 19, 2026 03:10

maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_submit_with_arguments_dialog branch from 5e51121 to b7596cf Compare February 19, 2026 03:10

graphite-app Bot changed the base branch from graphite-base/1767 to master February 19, 2026 03:10

feat: use secrets in submit with arguments dialog

50a917d

maxy-shpfy force-pushed the 02-06-feat_use_secrets_in_submit_with_arguments_dialog branch from b7596cf to 50a917d Compare February 19, 2026 03:10

maxy-shpfy merged commit 7ff1871 into master Feb 19, 2026
7 of 8 checks passed

maxy-shpfy deleted the 02-06-feat_use_secrets_in_submit_with_arguments_dialog branch February 19, 2026 03:37

Conversation

maxy-shpfy commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

Checklist

Screenshots

Test Instructions

Additional Comments

Uh oh!

maxy-shpfy commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mbeaulne Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

maxy-shpfy Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

maxy-shpfy Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

camielvs Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

maxy-shpfy Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

camielvs commented Feb 18, 2026

Uh oh!

maxy-shpfy commented Feb 18, 2026

Uh oh!

maxy-shpfy commented Feb 18, 2026

Uh oh!

camielvs commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maxy-shpfy commented Feb 18, 2026

Uh oh!

camielvs commented Feb 18, 2026

Uh oh!

Uh oh!

maxy-shpfy commented Feb 18, 2026

Uh oh!

camielvs left a comment

Choose a reason for hiding this comment

Uh oh!

maxy-shpfy commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

maxy-shpfy commented Feb 6, 2026 •

edited

Loading

maxy-shpfy commented Feb 6, 2026 •

edited

Loading

camielvs commented Feb 18, 2026 •

edited

Loading

maxy-shpfy commented Feb 19, 2026 •

edited

Loading