Skip to content

4. Add shared playground UI and JSON editor#3110

Merged
anish-sahoo merged 1 commit into
cog-playgroundfrom
playground/3b-shared-ui
Jul 15, 2026
Merged

4. Add shared playground UI and JSON editor#3110
anish-sahoo merged 1 commit into
cog-playgroundfrom
playground/3b-shared-ui

Conversation

@anish-sahoo

@anish-sahoo anish-sahoo commented Jul 14, 2026

Copy link
Copy Markdown
Member

@anish-sahoo anish-sahoo requested a review from a team as a code owner July 14, 2026 18:26

@ask-bonk ask-bonk Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm Bonk, and I've done a quick review of your PR.

One issue found in the JSON editor tests and configuration related to keyboard accessibility.

Comment thread playground/src/components/editor/JsonEditor.test.tsx
Comment thread playground/src/components/editor/config.ts
@ask-bonk

ask-bonk Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

I'm Bonk, and I've done a quick review of your PR.

  1. Summary: Adds shared playground UI components (segmented tabs, status badges, CodeMirror JSON editor) and responsive styles with colocated tests.

  2. Issues:

    • High (test failure / accessibility): JsonEditor.test.tsx:144 asserts fireEvent.keyDown(...).toBe(true), but fireEvent returns an Event object (not a boolean), so the test will always fail. Additionally, CodeMirror's defaultKeymap traps the Tab key for indentation, which contradicts the test's stated goal of leaving Tab available for keyboard navigation. I've posted suggestions on the PR for both the test assertion and the keymap configuration.

github run

@anish-sahoo anish-sahoo merged commit e2227d0 into cog-playground Jul 15, 2026
42 checks passed
@anish-sahoo anish-sahoo deleted the playground/3b-shared-ui branch July 15, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants