1. Add Go playground server and handlers#3109
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
I'm Bonk, and I've done a quick review of your PR.
This PR adds the internal playground command, static server, reverse proxy, webhook relay, and lifecycle handling with comprehensive tests. Overall the code is well-structured and secure.
Issue found:
- Protocol-relative redirects are not stripped in the proxy (medium severity). The
ModifyResponsehook strips absolute redirects to prevent pivoting the browser to unintended hosts, but protocol-relative redirects (e.g.//169.254.169.254/...) bypass the check becauseurl.ParsesetsIsAbs()to false when the scheme is empty. These should also be stripped.
A suggestion comment with the fix and an updated test is posted below.
Contributor
|
Posted a review on PR #3109. Found one actionable issue: protocol-relative redirects (e.g. |
This was referenced Jul 14, 2026
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.