2. Add playground frontend scaffold and early CI#3108
Merged
Conversation
This was referenced Jul 14, 2026
Contributor
|
@anish-sahoo Bonk workflow was cancelled. View workflow run · To retry, trigger Bonk again. |
Contributor
There was a problem hiding this comment.
I'm Bonk, and I've done a quick review of your PR.
Summary: Scaffold React/Vite playground frontend with embedded asset pipeline and CI integration.
Issues found:
- Artifact action version mismatch (Medium):
actions/upload-artifact@v6is used to upload playground assets, butactions/download-artifact@v8is used to download them. These should be aligned to the same major version to avoid compatibility surprises. - Unused change-detection output (Low): The
playground-changesjob computes achangedoutput, but no downstream job referencesneeds.playground-changes.outputs.changed. All playground jobs andbuild-cogrun unconditionally regardless, making the change detection dead code for now.
Contributor
|
Review posted successfully to PR #3108. Issues flagged:
|
Member
Author
|
Review disposition:
The inline artifact threads are resolved. |
markphelps
reviewed
Jul 14, 2026
| - arm64 | ||
| main: ./cmd/cog | ||
| tags: | ||
| - playground_assets |
markphelps
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.