Skip to content

2. Add playground frontend scaffold and early CI#3108

Merged
anish-sahoo merged 1 commit into
cog-playgroundfrom
playground/2-scaffold-ci
Jul 14, 2026
Merged

2. Add playground frontend scaffold and early CI#3108
anish-sahoo merged 1 commit into
cog-playgroundfrom
playground/2-scaffold-ci

Conversation

@anish-sahoo

@anish-sahoo anish-sahoo commented Jul 14, 2026

Copy link
Copy Markdown
Member

@ask-bonk

ask-bonk Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@anish-sahoo Bonk workflow was cancelled.

View workflow run · To retry, trigger Bonk again.

@ask-bonk ask-bonk Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm Bonk, and I've done a quick review of your PR.

Summary: Scaffold React/Vite playground frontend with embedded asset pipeline and CI integration.

Issues found:

  1. Artifact action version mismatch (Medium): actions/upload-artifact@v6 is used to upload playground assets, but actions/download-artifact@v8 is used to download them. These should be aligned to the same major version to avoid compatibility surprises.
  2. Unused change-detection output (Low): The playground-changes job computes a changed output, but no downstream job references needs.playground-changes.outputs.changed. All playground jobs and build-cog run unconditionally regardless, making the change detection dead code for now.

Comment thread .github/workflows/ci.yaml
Comment thread .github/workflows/release-build.yaml
@ask-bonk

ask-bonk Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Review posted successfully to PR #3108.

Issues flagged:

  1. Artifact action version mismatchactions/upload-artifact@v6 paired with actions/download-artifact@v8 in both CI and release workflows. Suggested aligning to the same major version.
  2. Unused change-detection output — The playground-changes job computes a changed output that no downstream job consumes, making it dead code for now.

github run

@anish-sahoo

Copy link
Copy Markdown
Member Author

Review disposition:

  • Keeping actions/upload-artifact@v6 with actions/download-artifact@v8: the actions are independently versioned, this pairing is already used by the release workflow, and download v8 verifies artifact digests.
  • playground-changes.outputs.changed is intentionally introduced in this early CI stage and consumed by final PR 10. Compose playground app and add browser e2e #3112 to gate Playwright.

The inline artifact threads are resolved.

Comment thread .goreleaser.yaml
- arm64
main: ./cmd/cog
tags:
- playground_assets

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats this for?

@anish-sahoo
anish-sahoo merged commit 6feed4a into cog-playground Jul 14, 2026
85 of 88 checks passed
@anish-sahoo
anish-sahoo deleted the playground/2-scaffold-ci branch July 14, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants