You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I reviewed all 22 files in PR #3107 by reading the core implementation (hooks, utils, components) and tests. I identified one issue where the async prediction flow's eventSourceReady promise rejection is unhandled if the EventSource fails before the onerror handler is attached, which could cause an unhandled promise rejection.
Reviewed the reported EventSource race. eventSourceReady installs onerror synchronously in its Promise executor; connection failures are awaited in run()'s try/catch, and the post-open handler is attached before a later browser task can deliver an error. No unhandled rejection path was found, so no code change is needed. Existing coverage includes post-connect failure and connection timeout.
This is a top-level comment, so GitHub provides no review thread to resolve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.