Skip to content

fix: honour flipped standard-DH joints in DHLink.A - #618

Open
tahazarif10 wants to merge 2 commits into
petercorke:mainfrom
tahazarif10:fix/563-dhlink-flip
Open

fix: honour flipped standard-DH joints in DHLink.A#618
tahazarif10 wants to merge 2 commits into
petercorke:mainfrom
tahazarif10:fix/563-dhlink-flip

Conversation

@tahazarif10

Copy link
Copy Markdown

Fixes #563

Summary

Use the variable joint ET (self.v) when applying flip in DHLink.A() instead of assuming the last ET in the sequence is the joint ET.

For standard DH links, constant transforms such as d, a, or alpha can follow the joint ET, so self.ets[-1].isflip may inspect the wrong ET.

Tests

Added regression coverage for both revolute and prismatic standard-DH links with flip=True.

  • python -m pytest tests/test_DHRobot.py -k test_A_flip_standard_dh -q
    • 1 passed
  • python -m pytest tests/test_DHRobot.py -q
    • 71 passed, 1 skipped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible bug: DHLink.A() checks self.ets[-1].isflip instead of the joint ET

1 participant