Skip to content

fix: use core LNURL-pay validation#1048

Merged
piotr-iohk merged 1 commit into
ovi/release-2.3.0from
fix/lnurl-pay
Jun 26, 2026
Merged

fix: use core LNURL-pay validation#1048
piotr-iohk merged 1 commit into
ovi/release-2.3.0from
fix/lnurl-pay

Conversation

@ovitrif

@ovitrif ovitrif commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR:

  1. Updates the app from Android release v2.3.0 to bitkit-core 0.1.74.
  2. Routes LNURL-pay invoice fetching through core with full LnurlPayData.
  3. Removes app-local LNURL-pay invoice callback fetching while leaving withdraw/channel behavior unchanged.
  4. Maps core invoice validation errors to a neutral payment-canceled message and adds repository coverage.

Patch commit: a960a3499cc38535a2c57803272e694b5c296503
Core release: https://github.com/synonymdev/bitkit-core/releases/tag/v0.1.74

Refs:

Preview

N/A

QA Notes

Manual Tests

  • 1. Send -> scan LNURL-pay request -> complete payment: invoice fetch and send behavior match the requested payment.
  • 2. regression: Send -> scan LNURL-withdraw or LNURL-channel request: existing withdraw/channel behavior still works.

Automated Checks

  • Unit tests added: LightningRepoTest covers core delegation and validation-error handling.
  • Local verification: just test.
  • Runtime proof: Android and iOS before/after LNURL-pay validation recordings completed locally.

@ovitrif ovitrif changed the base branch from master to ovi/release-2.3.0 June 25, 2026 22:27
@greptile-apps

This comment has been minimized.

greptile-apps[bot]

This comment was marked as resolved.

chatgpt-codex-connector[bot]

This comment was marked as resolved.

@ovitrif ovitrif self-assigned this Jun 25, 2026
@ovitrif ovitrif requested review from jvsena42 and piotr-iohk June 25, 2026 23:22

@ovitrif ovitrif left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a few nits that must be addressed. PR changes should be squashed into a single commit with same message as PR name

Comment thread app/src/main/java/to/bitkit/viewmodels/ProbingToolViewModel.kt Outdated
Comment thread app/src/main/java/to/bitkit/viewmodels/ProbingToolViewModel.kt Outdated
Comment thread app/src/main/java/to/bitkit/viewmodels/AppViewModel.kt Outdated
@ovitrif

ovitrif commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator Author

added a few nits that must be addressed. PR changes should be squashed into a single commit with same message as PR name

Addressed the review nits in the attached threads and squashed the branch into a single commit named fix: use core LNURL-pay validation.

Resolved in a960a34

@piotr-iohk piotr-iohk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Manual test on staging regtest: normal LN + QuickPay on/off OK. CI @lnurl_1 green - sufficient regression for the LNURL-pay validation hotfix.

@piotr-iohk piotr-iohk merged commit af08814 into ovi/release-2.3.0 Jun 26, 2026
21 of 31 checks passed
@piotr-iohk piotr-iohk deleted the fix/lnurl-pay branch June 26, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants