chore: release 2.3.1#1049
Conversation
fix: use core LNURL-pay validation
Co-authored-by: Cursor <cursoragent@cursor.com>
This comment was marked as off-topic.
This comment was marked as off-topic.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| @Suppress("TooGenericExceptionCaught") | ||
| suspend inline fun <R> runSuspendCatching(block: () -> R): Result<R> = | ||
| try { | ||
| Result.success(block()) | ||
| } catch (c: CancellationException) { | ||
| throw c | ||
| } catch (e: Throwable) { | ||
| Result.failure(e) | ||
| } | ||
| suspend inline fun <T> runSuspendCatching(crossinline block: suspend () -> T): Result<T> = try { | ||
| Result.success(block()) | ||
| } catch (error: Throwable) { | ||
| Result.failure(error) | ||
| } | ||
|
|
There was a problem hiding this comment.
nit: needs to be patched/replaced with existing implementation of runSuspendCatching from master.
Can be done before merge to master, as merging hygiene step, no need to impact the actual patch release.
ovitrif
left a comment
ovitrif
left a comment
There was a problem hiding this comment.
Added another nit, again, no changes for 2.3.1, this is only merge hygiene to cover all conflicts reported.
| barcode-scanning = { module = "com.google.mlkit:barcode-scanning", version = "17.3.0" } | ||
| biometric = { module = "androidx.biometric:biometric", version = "1.4.0-alpha05" } | ||
| bitkit-core = { module = "com.synonym:bitkit-core-android", version = "0.1.73" } | ||
| bitkit-core = { module = "com.synonym:bitkit-core-android", version = "0.1.74" } |
There was a problem hiding this comment.
nit: needs rebuilding bitkit-core on latest main there after the 0.1.74 changes merged with HEAD, version bump and bindings regen'ed.
|
@ovitrif I'd leave conflict resolution and addressing nits to you to make this mergable, since you have better context on the fix. (same for corresponding ios PR) |
Thank you sir, best reasoning for this 🙏 Wrapping it up for both repos 👀 |
2 participants
Summary
Hotfix release 2.3.1 (build 183) on top of v2.3.0.
Description
LnurlPayDatavalidationversionCode: 182 → 184versionName: 2.3.0 → 2.3.1Release
ovi/release-2.3.0Preview
N/A
QA Notes
@lnurl_1green with matching e2e branch (fix/lnurl-pay@d00494d)LightningRepoTestMade with Cursor