fix: validate LNURL-pay amount#115
Conversation
|
LGTM! Only small items that popped up were the following: 1. Dead code from a checked-in reversalCommit 1 added a LUD-06 description-hash / metadata check; commit 2 removed it. The result is:
2. No HTTP timeout on the callback fetchThe callback uses |
|
Thanks @coreyphillips, reason to keep API surface changes smallest was for temporary reasons to not invalidate too much of previous session's testing; more cleanup will follow on this PR before merging it back to master 🙏🏻 Then we can change apps too so they don't need handling of "dead code" like |
# Conflicts: # Cargo.lock # Cargo.toml # Package.swift # bindings/android/gradle.properties # bindings/android/lib/src/main/jniLibs/arm64-v8a/libbitkitcore.so # bindings/android/lib/src/main/jniLibs/armeabi-v7a/libbitkitcore.so # bindings/android/lib/src/main/jniLibs/x86/libbitkitcore.so # bindings/android/lib/src/main/jniLibs/x86_64/libbitkitcore.so # bindings/android/lib/src/main/kotlin/com/synonym/bitkitcore/bitkitcore.android.kt # bindings/android/lib/src/main/kotlin/com/synonym/bitkitcore/bitkitcore.common.kt # bindings/ios/BitkitCore.xcframework.zip # bindings/ios/BitkitCore.xcframework/ios-arm64-simulator/libbitkitcore.a # bindings/ios/BitkitCore.xcframework/ios-arm64/libbitkitcore.a # bindings/python/bitkitcore/libbitkitcore.dylib
Description
This PR:
bitkit-coreto0.1.75and updates generated bindings.Releases:
Preview
N/A
QA Notes
Manual Tests
N/A
Automated Checks
cargo fmtcargo test modules::lnurl./build.sh allswift package compute-checksum bindings/ios/BitkitCore.xcframework.zipgit diff --checksha256:9e4c13246dee06e38491d4112029352b60032df54ac7ed885a64375186c6dc3bv0.1.75