fix(swift): use Slider/Label/Button's label kwarg, not deprecated desc - #622
Open
petercorke wants to merge 1 commit into
Open
fix(swift): use Slider/Label/Button's label kwarg, not deprecated desc#622petercorke wants to merge 1 commit into
petercorke wants to merge 1 commit into
Conversation
swift-sim renamed the desc constructor kwarg/property to label on all SwiftElement subclasses (jhavl/swift#135) -- desc still works via a deprecation shim, but update RTB's own usages to the new name rather than carry the warning forward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
swift-simrenamed thedescconstructor kwarg/property tolabelon allSwiftElementsubclasses (jhavl/swift#135) —descstill works via a deprecation shim, but this updates RTB's own usages to the new name rather than carry the warning forwardsrc/roboticstoolbox/demo/tripleangledemo.py,src/roboticstoolbox/demo/twistdemo.py, andexamples/teach_swift.pyTest plan
pytest tests/test_demo.py— coverstripleangledemo/twistdemoconstruction, no regressionsfeat/element-desc-to-label+feat/label-compactbranches (both still open, unmerged) — noDeprecationWarnings raised🤖 Generated with Claude Code