ci: re-add robot_descriptions caching, keyed by python-version this time - #612
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #612 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 142 142
Lines 13898 13898
=====================================
Misses 13898 13898 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
PR #530 added actions/cache steps for ~/.cache/robot_descriptions, but they were removed in PR #536: robot_descriptions wasn't even a declared dependency at the time, so every run hit ModuleNotFoundError before any clone was attempted -- the caching solved a problem that didn't exist yet, and had its own bug (cache key was OS-only, so it couldn't help across the os x python-version matrix's parallel jobs anyway). That dependency gap is long fixed, and robot_descriptions is now genuinely exercised (YuMi, Valkyrie, UR3/5/10, Jaco, PR2, ...). Hit a concrete instance of the predicted failure mode directly: a real git-clone timeout in the macos-latest/3.12 job of PR #611's first CI run. Re-adding caching with the corrected key (includes python-version) to test-core, test, and coverage -- and also docs-build, which wasn't covered by the original PR but genuinely needs it too: intro.rst's YuMi example runs as a live `.. runblock::` during the Sphinx build.
petercorke
force-pushed
the
ci/cache-robot-descriptions
branch
from
August 17, 2026 21:17
63cefd0 to
fe7ca56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to RTB!
Summary
PR #530 added
actions/cachesteps for~/.cache/robot_descriptions, but they were removed in PR #536:robot_descriptionswasn't even a declared dependency at the time, so every run hitModuleNotFoundErrorbefore any clone was attempted — the caching solved a problem that didn't exist yet, and had its own bug (cache key was OS-only, so it couldn't help across theos x python-versionmatrix's parallel jobs anyway).That dependency gap is long fixed, and
robot_descriptionsis now genuinely exercised (YuMi, Valkyrie, UR3/5/10, Jaco, PR2, ...). Hit a concrete instance of the predicted failure mode directly: a real git-clone timeout in themacos-latest/3.12 job of PR #611's first CI run (unrelated to that PR's own change — just an ordinary transient network flake againstrobot_descriptions' upstream asset repos).Re-adding caching with the corrected key (now includes
python-version) totest-core,test, andcoverage— and alsodocs-build, which wasn't covered by the original PR but genuinely needs it too:intro.rst's YuMi example runs as a live.. runblock::during the Sphinx build.Related issue
Checklist
Only the first item below is checked automatically — the rest are a self-check for you before requesting review, nothing currently verifies them for you.
type: description) — checked automatically, see the "Check PR title" statuspytest)X | Y,list[X], notUnion/Optional/List):param:,:returns:; type hints in the signature cover types now,:type:/:rtype:are rarely needed)