ci: remove robot_descriptions caching, built on wrong diagnosis#536
Merged
Conversation
PR #530 added actions/cache steps for ~/.cache/robot_descriptions, reasoning the lazy git-clone was slow/flaky against the test timeout. The real problem was that robot_descriptions was never a declared dependency at all — every run hit ModuleNotFoundError immediately, before any clone was attempted. Now that the actual dependency is fixed, this caching solves a problem that was never real, and has its own bug (cache key doesn't include python-version, so it can't help within a single run's parallel os x python-version matrix anyway). See tech-debt.md for the full reasoning and what to do instead if CI timing becomes a real issue now that robot_descriptions is genuinely exercised. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/cachesteps for~/.cache/robot_descriptionsintest-core/test/coverage, theorizing the lazy git-clone was slow/flaky against the test timeout.robot_descriptionswas never a declared dependency at all — every run hitModuleNotFoundErrorimmediately, no clone ever attempted. The caching was solving a symptom of a problem that didn't exist.robot-descriptions-v1-${{ runner.os }}— nopython-version— but thetestjob matrix isos × python-version, running in parallel, so it couldn't help within a single run anyway.URDFRobot.py's_load_rd_module(trying{name}_descriptionthen{name}_official_description, hiding therobot_descriptionsimplementation detail from user-facing errors) — that's legitimate, separate, deliberate UX, unrelated to this.tech-debt.md, including what to do instead if CI timing becomes a real issue now thatrobot_descriptionsis genuinely exercised.🤖 Generated with Claude Code