fix(deps): don't require coal on Windows, fix stale install docs#531
Open
petercorke wants to merge 2 commits into
Open
fix(deps): don't require coal on Windows, fix stale install docs#531petercorke wants to merge 2 commits into
petercorke wants to merge 2 commits into
Conversation
coal has no Windows wheels on PyPI and its sdist can't build there either (needs cmeel-assimp>=6.0.5, unavailable for Windows), so pip install .[dev] hard-failed on every Windows CI job. Mark coal sys_platform != 'win32' in the collision/dev/all extras; the test suite already skips collision tests gracefully when coal is absent. Also fixes README's install/extras section, which still described a bullet/pybullet-based collision extra that no longer exists in pyproject.toml, and adds docs/source/install.rst since the Sphinx docs had no install page at all. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…r plan Captures the release-please single-branch/single-package limitation, the stacked-PRs-on-red-main failure mode from today's CI work, the no-approval -gate fact about the pypi deployment environment, and the queued rtb-data -> packages/rtb-data move. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
coalhas no Windows wheels on PyPI and its sdist can't build there (needscmeel-assimp>=6.0.5, unavailable for Windows) — this was hard-failingpip install .[dev]on every Windows CI job. Markcoalsys_platform != 'win32'in thecollision/dev/allextras.coalis absent (skip_no_collision_checkingmarker + lazy_require_coal()), so no test changes needed.bullet/pybullet-based collision extra that no longer exists inpyproject.toml(drifted when the backend moved tocoal).docs/source/install.rst(+ toctree entry) — the Sphinx docs had no install page at all.intro.rststill narrates PyBullet as the collision backend) and the Windows/coal tradeoff analysis intech-debt.mdfor later.Test plan
Install packagestep succeeds (previously failed oncoal/cmeel-assimp)Teststep runs and collision tests are skipped, not failedinstall.rstpage🤖 Generated with Claude Code