Add unreleased-schema-change gold answer (synthetic__upgrade-clean-05)#746
Closed
gggdttt wants to merge 1 commit into
Closed
Add unreleased-schema-change gold answer (synthetic__upgrade-clean-05)#746gggdttt wants to merge 1 commit into
gggdttt wants to merge 1 commit into
Conversation
Negative example locking the BCQuality guard 'unreleased-schema-change-needs-no-upgrade-path' (BCQuality #112). A brand-new, never-released app (app.json 1.0.0.0, no released baseline) adds persisted setup/log tables, fields, and an enum. New schema in an unreleased app needs no upgrade or data-migration code, so a data-loss/breaking-migration finding is a false positive. expected_comments is empty; the reviewer must stay silent. Derived from online-eval FP cluster (PR 8167). Validated: git apply --check clean against base 70fd0246; loader accepts 101 entries.
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds one synthetic negative gold answer to dataset/codereview.jsonl:
synthetic__upgrade-clean-05.Why
Locks the BCQuality guard
unreleased-schema-change-needs-no-upgrade-path(added in BCQuality #112) with a regression test. That guard has no BC-Bench coverage today, so a future skill/knowledge change could silently regress it.Scenario
A brand-new, never-released app (
app.jsonversion1.0.0.0, no released baseline) adds:Handy Tools Setup(persisted setup table)Handy Tools Activity Log(persisted log table)Handy Tools Activity(enum)New schema in an unreleased app has no shipped customer data to preserve, so it needs no upgrade or data-migration code. A data-loss / breaking-migration / obsoletion finding here is a false positive.
expected_comments: []— the reviewer must stay silent.Validation
git apply --checkclean against base70fd0246.