dataset(code-review): BC apps negative-feedback FP gold answers (7 entries)#745
Draft
gggdttt wants to merge 5 commits into
Draft
dataset(code-review): BC apps negative-feedback FP gold answers (7 entries)#745gggdttt wants to merge 5 commits into
gggdttt wants to merge 5 commits into
Conversation
…_style-018)
Encodes the tooltip-inheritance boundary as a code-review gold answer. A page binds three Vendor fields with no inline ToolTip: 'No.' and 'Name' inherit their source-field tooltips and must NOT be flagged (false-positive guard), while the field bound to a same-diff tableextension field ('Sample Note') that itself has no ToolTip has nothing to inherit and MUST be flagged medium. Guards against both over-flagging inherited fields and silently deferring the genuinely-missing case to compiler AA0218, whose severity is per-app configurable and often disabled.
gggdttt
marked this pull request as draft
July 20, 2026 12:52
…old answers Consolidates the BC apps negative-feedback batch-1 gold answers into this single PR (per request: one PR for all gold answers): synthetic__upgrade-clean-05 (upgrade): brand-new never-released app adding persisted schema needs no upgrade path; a migration/data-loss finding is a FP. From FP cluster PR 8167. synthetic__perf-clean-01 (performance): cue DrillDownPageId to a page whose SourceTableView filter matches the FlowField; effective filter lives outside the changed hunk, so an 'unfiltered drill-down' finding is a FP. From FP cluster PR 8124. synthetic__error-clean-01 (error-handling): page OnInsertRecord/OnModifyRecord omit exit(true); Boolean page record triggers default to true, so a 'returns false, blocking inserts' finding is a FP. From FP cluster PR 8419.
gggdttt
changed the title
3 negative examples matching new BCQuality guards (PR 8290/8584/8617)
gggdttt
changed the title
added 2 commits
July 21, 2026 10:40
Local engine run flagged the FlowField SIFT gap (AA0232) and missing tooltips (AA0218) as real defects; a negative example must be otherwise-clean so the only tested construct (CalcFields in OnAfterGetCurrRecord) is what the guard suppresses. Re-run confirms 0 findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Single PR for the BC apps negative-feedback batch-1 gold answers — four
code-reviewsynthetic entries indataset/codereview.jsonlthat lock in BCQuality precision guards (PRs #112 / #117) as offline regressions. Every entry is new-files-only withexpected_comments: [], so any finding the agent emits on them costs precision.Entries
synthetic__style-018ui/bound-page-field-inherits-source-field-tooltip(#117)synthetic__upgrade-clean-05upgrade/unreleased-schema-change-needs-no-upgrade-path(#112)synthetic__perf-clean-01performance/page-effective-filter-may-live-outside-the-diff(#112)synthetic__error-clean-01error-handling/page-boolean-triggers-default-to-true(#112)1.0.0.0, no released baseline) adds persisted tables + enum. New schema in an unreleased app has no shipped data to preserve → a migration / data-loss / obsoletion finding is a false positive.DrillDownPageIdto a list page whoseSourceTableViewalready filters the result set (Status = Open), matching the cue FlowField. The effective filter lives on the drill-down page, outside the changed hunk → an "unfiltered / full-table drill-down" finding is a false positive.OnInsertRecord/OnModifyRecordtriggers do work but omit an explicitexit(true). Page Boolean record triggers returntrueby default → a "returns false, blocking all inserts / discards all edits" finding is a false positive.Validation
CodeReviewEntry.load(...)→ 104 entries, all four ids present.git apply --checkclean against base70fd0246a0a4dbc72cb183ca719106722c03be4d.Tracked in ADO 639657. Supersedes and consolidates the earlier per-guard PRs (#746, #747), which can be closed in favor of this one.