Add FP gold answers: page-effective-filter and page-boolean-triggers#747
Closed
gggdttt wants to merge 1 commit into
Closed
Add FP gold answers: page-effective-filter and page-boolean-triggers#747gggdttt wants to merge 1 commit into
gggdttt wants to merge 1 commit into
Conversation
Two new-files-only synthetic code-review negative examples with empty expected_comments, locking in BCQuality #112 precision guards as offline regressions: synthetic__perf-clean-01 (performance): cue DrillDownPageId to a list page whose SourceTableView filter matches the FlowField; the effective filter lives outside the changed hunk, so a 'unfiltered drill-down' finding is a FP. From online-eval FP cluster PR 8124. synthetic__error-clean-01 (error-handling): page OnInsertRecord/OnModifyRecord omit exit(true); Boolean page record triggers default to true, so a 'returns false, blocking inserts' finding is a FP. From online-eval FP cluster PR 8419.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds two
code-reviewnegative-example gold answers todataset/codereview.jsonlthat lock in BCQuality precision guards from PR #112 as offline regressions. Both are new-files-only synthetic entries withexpected_comments: []— any finding the agent emits on them costs precision.Entries
synthetic__perf-clean-01performance/page-effective-filter-may-live-outside-the-diffsynthetic__error-clean-01error-handling/page-boolean-triggers-default-to-trueDrillDownPageIdto a list page whoseSourceTableViewalready filters the result set (Status = Open), matching the cue FlowField's own filter. The effective filter lives on the drill-down page, outside the changed field's hunk, so the drill-down is not unfiltered. A "drills down to an unfiltered/full-table list" finding is a false positive.OnInsertRecord/OnModifyRecordtriggers do work but omit an explicitexit(true). Page Boolean record triggers returntrueby default, so the insert/modify still proceeds. A "returns false, blocking all inserts / discards all edits" finding is a false positive.Validation
CodeReviewEntry.load(...)→ 102 entries, both new ids present.git apply --checkclean against base70fd0246a0a4dbc72cb183ca719106722c03be4d.Part of the BC apps negative-feedback batch-1 gold-answer set (tracked in ADO 639657). Companion to #745 (tooltip inheritance) and #746 (unreleased schema).