fix(studio): resolve flat-inspector review defects#2225
Open
vanceingalls wants to merge 1 commit into
Open
Conversation
This was referenced Jul 11, 2026
Collaborator
Author
This was referenced Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 15 confirmed defects from a max-effort adversarially-verified review of the flat-inspector stack (#2120–#2190). One commit, stacked on top so the reviewed PRs below stay untouched.
Identity / data-loss cluster
handleHideAllSelectedpassed bare DOM ids/selectors into a lookup expecting scope-qualified timeline keys, and fired one un-awaited file write per element (last write wins). Now resolves through the canonicalresolveTimelineIdForSelection(newtimelineKeysForSelectionshelper) andtoggleTimelineElementHiddenacceptsstring[], hiding all keys in ONE atomic write via the existingsetElementsHiddenbatch path.PropertyPanelFlatwas keyed byid ?? selector, colliding for id-less same-selector siblings. Now keyed by the same 4-part identity the legacyColorGradingSectionused (extracted asselectionIdentityKey, deduped at both call sites). Same fix for duplicate React keys in the multi-select list.PromotableControlwrappers around Content / text Color / Font family, so var-bound values display from and commit to the variable default, and promote-to-variable ("◇ var") is back.clip-pathas "none" with a live reset icon. Now shows "custom" (re-select = guarded no-op), matching the legacy contract.data-startanddata-durationsequentially.createGsapLivePreviewused first-matchquerySelector; now resolves viaselectorIndex.FlatSlider cluster
onPointerUpwas missing thedisabledguard the other handlers had (plus adraggingRefguard against orphan pointerups).draggingRef, cleared on up/cancel).{centerTick && …}; every non-centerTick Grade slider'sonResetwas dead. Slot now renders forcenterTick || onReset.tabIndex,aria-valuemin/max, and Arrow/Page/Home/End handling (sliderKeyTargethelper).Smaller
/media/metadatafetch failure cachednullforever; failures are no longer cached.|| 1falsy-zero bug →Number.isFiniteguard.Tests
Hide 2 elementslabel), disabled-release no-commit, keyboard operation, mid-drag echo no-snap-back, non-centerTick reset reachable.main(sdkResolverShadow / sdkCutover / etc.), untouched by this stack.Review provenance: 50-agent max-effort workflow review (6 finder angles → 41 adversarial verifiers), 46/48 candidates confirmed, collapsed to 15 distinct defects — all fixed here.