refactor(studio): remove section pinning from the flat inspector#2135
Open
vanceingalls wants to merge 1 commit into
Open
refactor(studio): remove section pinning from the flat inspector#2135vanceingalls wants to merge 1 commit into
vanceingalls wants to merge 1 commit into
Conversation
3 tasks
Collaborator
Author
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Tenth PR in the flat inspector stack (see #2120 for the foundation and full stack list). Removes group pinning entirely — the pin button,
PinnedGroupRow,PinnedZoneDivider, theusePersistedPinnedGroupshook (deleted outright, including its test file), and thepinnedGroupsByElementTypefield fromstudioUiPreferences.ts.Stack: #2120 → ... → #2134 → #2135 (this).
Why
Explicit product decision: pinning added complexity without being worth keeping. Removing it also resolves the one known follow-up flagged in the previous PR (#2134) — an oversized pinned zone could silently clip content with no scrollbar, since there's no scroll fallback in the new fixed-header layout. With no pinned zone at all, that failure mode can't occur.
How
PropertyPanelFlat.tsx's group list no longer splits into pinned/unpinned — thebeforeOpen/openGroup/afterOpensplit (from refactor(studio): scroll only the open group's body, keep headers fixed #2134) now operates directly on the full group list.FlatGroupHeaderno longer acceptsisPinned/onTogglePin; the pin button is gone from its button row.PinnedGroupRowandPinnedZoneDividerdeleted frompropertyPanelFlatPrimitives.tsx.usePersistedPinnedGroups.tsand its test file deleted entirely.pinnedGroupsByElementTyperemoved fromStudioUiPreferencesand its read/write validation.Test plan
PropertyPanel.test.tsx,propertyPanelFlatPrimitives.test.tsx, andstudioUiPreferences.test.ts.oxlint/oxfmt/fallowclean.