refactor(studio): scroll only the open group's body, keep headers fixed#2134
Open
vanceingalls wants to merge 1 commit into
Open
Conversation
Collapsed group headers render in fixed, non-scrolling document flow above and below the open group; only the open group's own content scrolls, in a dedicated region. Also fixes the flat inspector footer's missing background. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This was referenced Jul 10, 2026
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ninth PR in the flat inspector stack (see #2120 for the foundation and full stack list). Collapsed group headers now render in fixed, non-scrolling document flow above and below the open group — always fully visible, in natural order. Only the open group's own body content scrolls, in a dedicated scrollable region between the two fixed header stacks. Also fixes the flat inspector footer's missing background (was fully transparent).
Stack: #2120 → ... → #2127 → #2135 (this).
Why
An earlier
position: sticky-based approach (collapsed headers stacking to the top/bottom edges as you scroll one shared container) was tried and refined live, but required sub-pixel-precision offset math and still hit a Chromium rounding quirk at the sticky-to-footer boundary. The user watched this live and asked for something architecturally simpler: headers that never move at all, with only the expanded section's content scrolling. This PR is that simpler design — collapsed here into one clean commit rather than shipping the sticky approach and then reverting it in a follow-up.How
PropertyPanelFlat.tsxsplits the group list intobeforeOpen/openGroup/afterOpenbased on the open group's position.beforeOpenandafterOpenrender as plain collapsed headers in normal flow;openGrouprenders its header (also fixed) followed by a dedicatedoverflow-y-autodiv holding just its body content.FlatGroupsplit into a header-onlyFlatGroupHeadercomponent — no morechildren/body prop, noposition: sticky, no offset math.PropertyPanelFlatFooter.tsxgained abg-panel-bgbackground (it was fully transparent, a real pre-existing bug independent of any scrolling approach).Test plan
getBoundingClientRect().topof every collapsed header and the footer before and after scrolling the open group's body — values were bit-for-bit identical, confirming headers genuinely never move.oxlint/oxfmt/fallowclean.