feat(studio): stack flat inspector headers as sticky top/bottom rails#2129
Closed
vanceingalls wants to merge 1 commit into
Closed
feat(studio): stack flat inspector headers as sticky top/bottom rails#2129vanceingalls wants to merge 1 commit into
vanceingalls wants to merge 1 commit into
Conversation
Collapsed group headers above the open group stick to the top of the panel in order, collapsed headers below stick to the bottom in order, and the open group's own header sticks just below the top stack, so headers never scroll out of view or overlap.
This was referenced Jul 10, 2026
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3 tasks
Collaborator
Author
|
Superseded — reworked into a simpler fixed-headers/scrollable-open-section-only design per user feedback, collapsed into a single clean PR instead of shipping this sticky-positioning approach and then reverting it in a follow-up. See the replacement PR in this same stack. |
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ninth PR in the flat inspector stack (see #2120 for the foundation and full stack list). Makes group headers sticky: collapsed headers above the currently-open group stack at the top of the panel in order, collapsed headers below it stack at the bottom in order, and the open group's own header stays pinned right below the top stack — so no header ever scrolls out of view.
Stack: #2120 → ... → #2127 → #2128 → #2129 (this).
Why
The flat accordion previously had zero sticky positioning on any header — confirmed live in the browser before starting (collapsed headers and the open group's title bar both scrolled away with the content). Requested directly from live testing of the parity fixes in #2127/#2128.
How
PropertyPanelFlat.tsxcomputes astackSide/stackOffsetPxfor each unpinned group based on its position relative to the open group: groups before it gettop: index * 40px, the open group itself getstop: (count of groups before it) * 40px, groups after it getbottom: (distance from the last group) * 40px. When nothing is open, everything falls back to top-stacking in order.FlatGroupappliesposition: stickywith the computed offset via inline style (not a static class, since the offset is per-instance) to both its collapsed-button and open-title-bar variants, with matchingz-10/bg-panel-bgso a stuck header renders opaquely above scrolling content, andmin-h-10on both variants so the 40px-per-header stacking math is pixel-accurate.PinnedGroupRow) and the pinned/unpinned divider are untouched — this only affects the one-open accordion's own headers.Test plan
position/top/bottom) rather than class-name matching, covering the full worked example (a middle group open, headers before and after it) and the "nothing open" fallback.oxlint/oxfmt/fallowclean.