refactor(manipulation): cut over to single robot model - #3431
Draft
TomCC7 wants to merge 2 commits into
Draft
Conversation
❌ 3 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution path
openspec/changes/refactor-control-coordinator-connectionsProblem
Manipulation still models configuration, planning state, execution, and visualization as maps of independently named robots. That duplicates namespaces, requires local/global joint-name translation, and prevents a bimanual robot from being planned as one coherent model.
Solution
ManipulationModuleConfig.robotswith one preparedmodel.left_arm; groups select canonical subsets of the one model.left_arm,right_arm, andboth_armsgroups.The legacy gripper hardware-ID path remains intentionally deferred to PR6 in the OpenSpec stack.
How to Test
Validated locally:
deno fmtwere unavailable in the local environment.AI assistance
Codex with GPT-5 implemented the refactor, migrated tests and blueprints, and ran validation under human direction.
Checklist