Skip to content

refactor(memory): rename memory2 package to memory - #3413

Open
spomichter wants to merge 2 commits into
mainfrom
chore/rename-memory2-to-memory
Open

refactor(memory): rename memory2 package to memory#3413
spomichter wants to merge 2 commits into
mainfrom
chore/rename-memory2-to-memory

Conversation

@spomichter

Copy link
Copy Markdown
Contributor

memory2 was a transitional name while the original dimos/memory package was being replaced. That package is gone — nothing is tracked under dimos/memory on main — so the 2 no longer distinguishes anything.

Pure rename, no behavior change:

  • dimos/memory2/dimos/memory/ (81 files, git mv so history follows)
  • dimos.memory2.*dimos.memory.* across 151 files (imports, docstrings, docs, CLI help text)
  • Memory2ReplayAdapterMemoryReplayAdapter (dimos/utils/testing/replay.py; the TimedSensorReplay alias is unchanged)
  • all_blueprints.py regenerated — 3 module paths (memory-module, recorder, semantic-search); blueprint/module keys are unchanged, they never carried the 2
  • .gitignore comment

No on-disk format, database, or public API surface changes. Existing recordings open exactly as before.

Verification

  • pytest --numprocesses=logical -m 'not (self_hosted or mujoco or self_hosted_large or web_browser)' (CI's exact invocation) → 3956 passed, 34 skipped, plus 4 failures in test_reactive, b1/test_connection, test_replay_bench[zenoh], and e2e_tests/test_control_coordinator — none of those files are touched by this change or reference memory, and all 4 pass on re-run in isolation (parallel-worker contention + a small local net.core.rmem_default).
  • pytest dimos/memory → 456 passed
  • mypy in a --only-group lint env → byte-identical output to a clean origin/main baseline (same 2 pre-existing stubs/ errors, same 958 files checked)

The memory2 name was transitional — the original dimos/memory package is
long gone (nothing tracked under that path), so the 2 no longer distinguishes
anything. Renames the package, the Memory2ReplayAdapter shim class, and all
prose references.

Pure rename: no behavior, API surface, or on-disk format changes.
@mintlify

mintlify Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
dimensional 🟢 Ready View Preview Aug 9, 2026, 7:51 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@greptile-apps

greptile-apps Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Too many files changed for review (151 files, 100 file limit).

Bypass the limit by tagging @greptile-apps to review.

@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.77124% with 16 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
dimos/mapping/cli/replay_marker.py 0.00% 3 Missing ⚠️
...os/experimental/world_belief/worldbelief_module.py 33.33% 2 Missing ⚠️
dimos/mapping/cli/replay.py 33.33% 2 Missing ⚠️
dimos/memory/cli/app.py 50.00% 2 Missing ⚠️
dimos/experimental/world_belief/world_belief.py 0.00% 1 Missing ⚠️
dimos/mapping/cli/test_cli.py 50.00% 1 Missing ⚠️
dimos/mapping/ray_tracing/test_transformer.py 0.00% 1 Missing ⚠️
dimos/memory/module.py 85.71% 1 Missing ⚠️
dimos/memory/store/sqlite.py 92.30% 1 Missing ⚠️
dimos/memory/vis/space/space.py 80.00% 1 Missing ⚠️
... and 1 more
@@           Coverage Diff           @@
##             main    #3413   +/-   ##
=======================================
  Coverage   76.09%   76.09%           
=======================================
  Files        1190     1190           
  Lines      115295   115307   +12     
  Branches    10367    10368    +1     
=======================================
+ Hits        87729    87740   +11     
  Misses      24554    24554           
- Partials     3012     3013    +1     
Flag Coverage Δ
OS-ubuntu-24.04-arm 70.28% <84.91%> (+0.12%) ⬆️
OS-ubuntu-latest 72.15% <90.81%> (+<0.01%) ⬆️
Py-3.10 72.14% <90.81%> (-0.01%) ⬇️
Py-3.11 72.14% <90.81%> (+<0.01%) ⬆️
Py-3.12 72.14% <90.81%> (+<0.01%) ⬆️
Py-3.13 ?
Py-3.14 70.28% <84.91%> (-1.87%) ⬇️
Py-3.14t 72.15% <90.81%> (+<0.01%) ⬆️
SelfHosted-Large 29.66% <58.56%> (+<0.01%) ⬆️
SelfHosted-Linux 35.83% <64.84%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
dimos/cli/dimos.py 64.47% <100.00%> (ø)
dimos/control/benchmarking/paths.py 68.63% <100.00%> (ø)
dimos/experimental/world_belief/recall.py 18.27% <100.00%> (ø)
.../experimental/world_belief/worldbelief_recorder.py 65.45% <100.00%> (ø)
dimos/hardware/sensors/lidar/pointlio/recorder.py 80.95% <100.00%> (ø)
dimos/imitation/collection/blueprint.py 88.23% <ø> (ø)
dimos/imitation/collection/recorder.py 100.00% <100.00%> (ø)
dimos/imitation/dataprep/build.py 29.41% <100.00%> (ø)
dimos/imitation/dataprep/core.py 87.30% <ø> (ø)
dimos/mapping/cli/map.py 35.47% <100.00%> (ø)
... and 96 more

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…paths

Stream registries store fully-qualified class names, so every database
written before the rename references dimos.memory2.*. Remap the prefix on
read — the classes are otherwise unchanged.
@spomichter
spomichter force-pushed the chore/rename-memory2-to-memory branch from df8c04e to f1b7e2c Compare August 9, 2026 18:03
@github-actions github-actions Bot added the ready-to-merge Required CI checks have passed on this PR label Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Required CI checks have passed on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant