Skip to content

ci: stop cancelling in-progress runs on new pushes#2191

Open
spomichter wants to merge 1 commit into
mainfrom
chore/remove-cancel-in-progress
Open

ci: stop cancelling in-progress runs on new pushes#2191
spomichter wants to merge 1 commit into
mainfrom
chore/remove-cancel-in-progress

Conversation

@spomichter
Copy link
Copy Markdown
Contributor

Problem

With cancel-in-progress: true, any new push to a PR immediately kills the running CI workflow. This includes commits pushed by autofix.ci (formatting fixes), which means:

  1. You push code
  2. CI starts running tests
  3. autofix.ci pushes a format commit 6 seconds later
  4. Your entire CI run gets cancelled
  5. PR shows X failures even though nothing actually failed

Example: https://github.com/dimensionalOS/dimos/actions/runs/26152674707

Fix

Set cancel-in-progress: false. Existing runs complete normally. New pushes still trigger their own CI run — they just queue instead of killing the previous one.

What is NOT affected

  • Intra-run fail-fast (matrix job cancellation when one job fails) — this is controlled by strategy.fail-fast on the matrix, completely independent
  • Concurrency grouping — still grouped per-PR, so runs are serialized (not parallel)

Tradeoff

Slightly more runner minutes on stale commits (old run finishes even if a new commit arrives). But no more phantom failures from autofix races.

With cancel-in-progress: true, any new push to a PR (including
autofix.ci formatting commits) immediately kills the running CI.
This causes phantom failures where all tests were passing but the
run shows as cancelled/failed.

Setting cancel-in-progress: false lets existing runs complete.
New pushes still get their own run — they just queue instead of
killing the previous one. Intra-run fail-fast (matrix job
cancellation on first failure) is unaffected.
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 20, 2026

Greptile Summary

The PR disables cancel-in-progress in the CI concurrency block to prevent phantom failures caused by autofix.ci formatting commits cancelling in-flight test runs. No issues found — clean, well-reasoned change.

Confidence Score: 5/5

Safe to merge — the one-line change is well-reasoned and does not touch any job logic.

The change is a single boolean flag flip in the concurrency block. The rest of the workflow — including the cross-job fail-fast job, the matrix fail-fast, and the per-PR concurrency group — is completely untouched and continues to behave as before.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/ci.yml Single-line change: cancel-in-progress flipped from true to false with the associated comment removed. Logic is correct and the rest of the workflow is untouched.

Reviews (1): Last reviewed commit: "ci: stop cancelling in-progress runs on ..." | Re-trigger Greptile

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@leshy
Copy link
Copy Markdown
Contributor

leshy commented May 20, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants