feat(lint): replace stock max-params with conformance-aware rule#53
Draft
natemoo-re wants to merge 1 commit into
Draft
feat(lint): replace stock max-params with conformance-aware rule#53natemoo-re wants to merge 1 commit into
natemoo-re wants to merge 1 commit into
Conversation
bombshell-dev/max-params keeps the 2-param limit for signatures we author, but exempts functions conforming to external APIs: override methods, members of classes that extends/implements, and inline callbacks.
🦋 Changeset detectedLatest commit: b9d6c2c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This was referenced Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 2-parameter limit is a design convention for APIs we author — but the stock rule also fired on signatures imposed by APIs we conform to (Node streams, platform-shaped interfaces), pushing agents toward whole-file
// oxlint-disable max-paramsheaders.bombshell-dev/max-paramskeeps the limit for authored signatures (free function declarations, variable-assigned functions, standalone-class members) and exempts conformance cases:overridemethodsextendsorimplements(the signature is imposed by the base/interface)Validation
runOxlintcovering all authored/exempt casesstdio.ts's stream_write(chunk, encoding, callback)override is now correctly silent — the exact clayterm failure mode from the logsmeta.schemato accept options (discovered the hard way)Includes changeset (minor).