feat(lint): make --fix actually fix things#57
Merged
Conversation
🦋 Changeset detectedLatest commit: e59f465 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
- oxlint --fix now chains into knip --fix: unused dependencies are removed from package.json (dead-code fix types require --strict; files are never deleted automatically) - new bombshell-dev/no-console-log rule replaces stock no-console: flags console.log with an auto-fixer to console.info (semantically neutral in Node — they are the same stdout write)
console.log → console.info across the CLI, applied by the new fixer.
Missing brace in printViolations grouping loop, stray rule-object closers in plugin.js, TS18048 on optional v.line in sort comparator.
natemoo-re
force-pushed
the
feat/lint-fix-pipeline
branch
from
July 26, 2026 00:08
4a2cfa6 to
e59f465
Compare
natemoo-re
marked this pull request as ready for review
July 26, 2026 00:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--fixpreviously only ranoxlint --fix, so agents hand-fixed everything else — burning tokens on deterministic work. This chains in the fixers the toolchain already has, plus one new custom rule.--fixnow removes unused dependencies/devDependencies frompackage.jsonviaknip --fix --fix-type dependencies. With--fix --strict, dead-code fix types (exports,types) are included. Unused files are never deleted automatically.bombshell-dev/no-console-logreplaces the stockno-consolerule:console.logis auto-fixed toconsole.info— semantically neutral in Node, where the two are aliases for the same stdout write. (326 hits in the session logs; previously every one was a manual edit.) Other unlisted console methods are flagged but not fixed.Verified end-to-end:
bsh lint --fixon a fixture rewritesconsole.log→console.infoand empties unuseddependencies, leaving "No issues found." This repo's own console sites were fixed the same way (separate commit).Sharp edge (documented in changeset)
knip fixes respect knip config — deps it can't trace (e.g. binaries referenced via
node_modules/.binpaths, as this repo does inutils.ts) look unused and will be removed. On the pre-#56 config,knip --fixstrippedoxlint/oxfmt/@typescript/native-previewfrom this repo's ownpackage.json. #56 (merged) fixed that config, so consumers on the new baseline are protected — but any project whose knip config lacks ignores for untraceable deps is exposed. This is knip's config-as-contract model, worth knowing before running--fixin a fresh project.Notes
fix()fixers withmeta.fixable: 'code'Includes changeset (minor).