chore: pay down dogfood lint debt#56
Draft
natemoo-re wants to merge 1 commit into
Draft
Conversation
- replace node:path with URL APIs in init/sync/fixture - throw coded ToolsError instead of generic Error - oxlintrc overrides: config files and rules/** exempt from import/no-default-export - Fixture.write/append accept strings (matches runtime behavior) - consolidate duplicate knip config into knip.jsonc (package.json#knip was being silently ignored) - raise vitest testTimeout to 15s for binary-spawning integration tests
🦋 Changeset detectedLatest commit: bb5beb4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The tools repo failed its own lint: 9 errors on main. This PR brings it to 1 — and that last one (
stdio.ts's stream_writeoverride) is resolved by design once #53 lands, so it's deliberately left alone rather than suppressed.node:path→ URL APIs ininit.ts(basename via pathname segments),sync.ts(newrelativeUrlPath/resolveLinkTargethelpers for symlink targets),fixture.tsToolsErrorreplaces the genericErrorintest.tspackage.json#knipwas silently ignored becauseknip.jsonctakes precedence — theignoreDependencieslist lived in the wrong place. Consolidated; 3 phantomunused-dependencywarnings goneoverrides:*.config.*andrules/**exempt fromimport/no-default-export(configs and oxlint plugins legitimately need default exports; also pre-clears theplugin.jserror that feat(lint): tier knip dead-code behind --strict, restructure output #51's project-wide scope surfaces)Fixture.write()/append()accept strings — the TS2345 infixture.test.tswas a type lie (typedUint8Array-only; runtime and all call sites used strings), fixed at the interfacetestTimeout: 15s— integration tests spawn real oxlint/knip binaries and flaked at 5s under loadValidation
bsh lintgoes from 9 errors → 1; knip warnings 3 → 0Includes changeset (minor).