feat(lint): tier knip dead-code behind --strict, restructure output#51
Draft
natemoo-re wants to merge 1 commit into
Draft
feat(lint): tier knip dead-code behind --strict, restructure output#51natemoo-re wants to merge 1 commit into
natemoo-re wants to merge 1 commit into
Conversation
- errors in full, warnings collapsed to per-rule counts (--warnings to show) - --format json machine-readable report - knip unused-export/type/file require --strict; dep hygiene always runs - fix tsgo silently checking nothing (TS5112): always project mode, explicit targets filter the report after the fact - default oxlint target widened from ./src to project-wide - disable unicorn/consistent-function-scoping and no-underscore-dangle - --fix exits non-zero only on remaining errors
🦋 Changeset detectedLatest commit: 795c65d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This was referenced Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Session-log analysis showed
bsh lint's signal was drowning in noise: "1 error, 41 warnings" reports trained agents to skim past everything, and knip's dead-code checks (909+unused-filehits) fired constantly mid-implementation — an export is "unused" until its consumer exists.--warningsexpands). Warnings never affect the exit code, so this keeps actual failures visible.--format jsonfor a machine-readable report ({ summary, violations }). Usepnpm -sto keep pnpm's banner out of stdout.--strict— a commit-time gate, not a TDD-loop gate. Dependency hygiene (unused deps/devDeps) still always runs.fixture.test.ts../srcto project-wide (gitignored paths respected), matching knip/tsgo scope.unicorn/consistent-function-scopingandno-underscore-dangleturned off — they fired frequently but were never deliberately enabled (inherited fromcategories).--fixnow exits non-zero only when errors remain (previously any warning failed the run).Validation
--strict/--warnings/--format jsonon this repo andcooper/packages/identitylint.ts(both touchrunOxlint); either order merges fineIncludes changeset (minor).