useNodeManager Hook#1082
Closed
camielvs wants to merge 2 commits into
Closed
Conversation
This was referenced Oct 7, 2025
Closed
Closed
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
camielvs
force-pushed
the
10-07-provide_node_manager
branch
from
e6f53b7 to
649681c
Compare
camielvs
force-pushed
the
10-07-usenodemanager_hook
branch
2 times, most recently
from
263ddb7 to
17ccb35
Compare
camielvs
force-pushed
the
10-07-provide_node_manager
branch
from
649681c to
0ade3f6
Compare
camielvs
force-pushed
the
10-07-usenodemanager_hook
branch
from
17ccb35 to
ee03616
Compare
camielvs
force-pushed
the
10-07-provide_node_manager
branch
2 times, most recently
from
34446e1 to
aad4aee
Compare
camielvs
force-pushed
the
10-07-usenodemanager_hook
branch
2 times, most recently
from
6c77cd9 to
1073324
Compare
camielvs
force-pushed
the
10-07-provide_node_manager
branch
from
aad4aee to
8547350
Compare
3 tasks
camielvs
force-pushed
the
10-07-usenodemanager_hook
branch
2 times, most recently
from
ccad217 to
379c1b4
Compare
This was referenced Oct 9, 2025
camielvs
force-pushed
the
10-07-usenodemanager_hook
branch
from
379c1b4 to
e2facc6
Compare
camielvs
force-pushed
the
10-07-provide_node_manager
branch
from
49aea78 to
3059e4f
Compare
camielvs
force-pushed
the
10-07-provide_node_manager
branch
from
4acb98a to
a9d2456
Compare
camielvs
force-pushed
the
10-07-usenodemanager_hook
branch
from
e6bbf75 to
65ed24b
Compare
camielvs
force-pushed
the
10-07-provide_node_manager
branch
from
a9d2456 to
bb1a463
Compare
camielvs
force-pushed
the
10-07-usenodemanager_hook
branch
from
65ed24b to
27bc1dc
Compare
camielvs
force-pushed
the
10-07-provide_node_manager
branch
from
bb1a463 to
e370c63
Compare
camielvs
force-pushed
the
10-07-usenodemanager_hook
branch
2 times, most recently
from
82ec352 to
1910574
Compare
camielvs
force-pushed
the
10-07-provide_node_manager
branch
2 times, most recently
from
0a7538b to
4f02c76
Compare
camielvs
force-pushed
the
10-07-usenodemanager_hook
branch
from
1910574 to
755167d
Compare
camielvs
force-pushed
the
10-07-provide_node_manager
branch
from
4f02c76 to
a957df5
Compare
camielvs
force-pushed
the
10-07-usenodemanager_hook
branch
2 times, most recently
from
089c958 to
b79c576
Compare
camielvs
force-pushed
the
10-07-provide_node_manager
branch
2 times, most recently
from
896ecc2 to
e1cbc87
Compare
camielvs
force-pushed
the
10-07-usenodemanager_hook
branch
2 times, most recently
from
4dce064 to
846582d
Compare
camielvs
force-pushed
the
10-07-provide_node_manager
branch
from
3fd626c to
ef00f3d
Compare
camielvs
force-pushed
the
10-07-usenodemanager_hook
branch
from
846582d to
1c05e06
Compare
3 tasks
camielvs
changed the base branch from
10-07-provide_node_manager
to
graphite-base/1082
camielvs
force-pushed
the
graphite-base/1082
branch
from
ef00f3d to
bd9b6ec
Compare
camielvs
force-pushed
the
10-07-usenodemanager_hook
branch
from
1c05e06 to
588f464
Compare
camielvs
changed the base branch from
graphite-base/1082
to
10-07-provide_node_manager
camielvs
force-pushed
the
10-07-provide_node_manager
branch
from
bd9b6ec to
c298c28
Compare
4 tasks
Collaborator
Author
|
Closed in favour of v2 Editor migration. See #2028 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a hook
useNodeManagerto simplify common node manager tasks. This is essentially a wrapper around NodeManager via ComponentSpecProvider.No change to app functionality. Implementation will come in upstack PRs.
Related Issue and Pull requests
Progresses https://github.com/Shopify/oasis-frontend/issues/261
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Wrapper around
nodeManager.tswithout any implementation. There isn't really any testing to do here as the operations are very simple.Additional Comments