Skip to content

Fix Node Replacement Issues on IO Rename#1083

Closed
camielvs wants to merge 1 commit into09-29-implement_node_managerfrom
10-08-fix_node_replacement_issues_on_io_rename
Closed

Fix Node Replacement Issues on IO Rename#1083
camielvs wants to merge 1 commit into09-29-implement_node_managerfrom
10-08-fix_node_replacement_issues_on_io_rename

Conversation

@camielvs
Copy link
Copy Markdown
Collaborator

@camielvs camielvs commented Oct 8, 2025 •
edited
Loading

Description

Follow-up to #846

This PR fixes the issue we were having with renamed IO nodes creating a replacement node in ReactFlow and thus causing issues with persistent state (e.g. selection & highlighting). This PR replaces the workaround useNodeSelectionTransfer logic with a simple migration via the new Node manager.

Related Issue and Pull requests

Closes https://github.com/Shopify/oasis-frontend/issues/296
Closes https://github.com/Shopify/oasis-frontend/issues/263
Closes https://github.com/Shopify/oasis-frontend/issues/331

Type of Change

  • Improvement

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  1. Rename an input node - it should update smoothly and the node or context panel should not flicker or close & reopen
  2. same as above for output node renaming

Additional Comments

This was referenced Oct 8, 2025
Closed
Closed
@camielvs Graphite App
Copy link
Copy Markdown
Collaborator Author

camielvs commented Oct 8, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camielvs camielvs force-pushed the 09-29-split_taskinput_and_taskoutput_node_ids_from_input_and_output_node_ids branch from b6be3d3 to 81c1c02 Compare October 8, 2025 20:02
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from cb246d1 to 10b7c60 Compare October 8, 2025 20:02
@camielvs camielvs changed the base branch from 09-29-split_taskinput_and_taskoutput_node_ids_from_input_and_output_node_ids to graphite-base/1083 October 8, 2025 20:08
@camielvs camielvs changed the base branch from graphite-base/1083 to 09-29-implement_node_manager October 8, 2025 20:09
This was referenced Oct 8, 2025
Closed
Closed
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from 81c1c02 to f7b4701 Compare October 8, 2025 20:17
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from 10b7c60 to 55e80d8 Compare October 8, 2025 20:17
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from f7b4701 to 6f7964f Compare October 9, 2025 00:37
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from 55e80d8 to 0dea688 Compare October 9, 2025 00:37
This was referenced Oct 9, 2025
Closed
Closed
Closed
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from 6f7964f to ed6dac3 Compare October 9, 2025 01:27
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch 2 times, most recently from d39d198 to f2ff89f Compare October 9, 2025 01:44
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch 2 times, most recently from 8b1c325 to cdf173e Compare October 9, 2025 16:52
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from f2ff89f to 45e9d85 Compare October 9, 2025 16:52
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from cdf173e to f6ee2d9 Compare October 9, 2025 17:04
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from 45e9d85 to 7e42fa6 Compare October 9, 2025 17:04
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from f6ee2d9 to b62b77d Compare October 9, 2025 17:15
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from 7e42fa6 to 5b6b0d0 Compare October 9, 2025 17:15
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from b62b77d to d1ad079 Compare October 9, 2025 18:46
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch 2 times, most recently from 2fa3659 to f7f0199 Compare October 9, 2025 19:19
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from d1ad079 to ba7a488 Compare October 9, 2025 19:19
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from 6d8f3be to 7b22173 Compare October 16, 2025 18:17
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch 2 times, most recently from 527f26e to d3f8f58 Compare October 17, 2025 17:36
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from 7b22173 to d042084 Compare October 17, 2025 17:36
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from d3f8f58 to 998d1bf Compare October 17, 2025 18:22
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch 2 times, most recently from 006b013 to 94dab5e Compare October 17, 2025 18:26
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch 4 times, most recently from 2d86930 to b6c0b7d Compare October 17, 2025 21:41
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from 3afa0a3 to 6e7153a Compare October 17, 2025 21:41
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from b6c0b7d to f4b579c Compare October 17, 2025 21:42
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from 0c17c58 to 80fe92b Compare October 22, 2025 20:18
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from f4b579c to 4190130 Compare October 22, 2025 20:18
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from 80fe92b to 4ebe9af Compare October 22, 2025 22:19
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from 4190130 to 292963c Compare October 22, 2025 22:19
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from 4ebe9af to a771300 Compare October 23, 2025 16:35
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from 292963c to 76acaa5 Compare October 23, 2025 16:35
@camielvs camielvs mentioned this pull request Oct 23, 2025
Closed
3 tasks
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from a771300 to b0d1e49 Compare October 23, 2025 20:05
@camielvs camielvs force-pushed the 10-08-fix_node_replacement_issues_on_io_rename branch from 76acaa5 to 349bbc8 Compare October 23, 2025 20:05
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from b0d1e49 to 2cb7d00 Compare October 23, 2025 20:11
This was referenced Oct 28, 2025
Closed
Closed
@camielvs Graphite App
Copy link
Copy Markdown
Collaborator Author

camielvs commented Apr 24, 2026

Closed in favour of v2 Editor migration. See #2028

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxy-shpfy maxy-shpfy Awaiting requested review from maxy-shpfy

@Mbeaulne Mbeaulne Awaiting requested review from Mbeaulne

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@camielvs @Mbeaulne @maxy-shpfy