Implement Node Manager#1004
Closed
camielvs wants to merge 1 commit into10-07-usenodemanager_hookfrom
Closed
Conversation
This was referenced Sep 29, 2025
Closed
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
62e4c7d to
8c27ed8
Compare
This was referenced Sep 30, 2025
8132fb5 to
af581a3
Compare
8c27ed8 to
46676ff
Compare
This was referenced Oct 2, 2025
af581a3 to
5b8b110
Compare
46676ff to
9cab80e
Compare
9cab80e to
50cbbc2
Compare
5b8b110 to
c55eb6c
Compare
c55eb6c to
aef47ff
Compare
2f84d5f to
10473ce
Compare
10473ce to
8396c6f
Compare
8396c6f to
83ecf4a
Compare
279521f to
2c6d7b6
Compare
ba7a488 to
fbccd60
Compare
63a6e06 to
e5d39ad
Compare
a167f91 to
a3cceee
Compare
e5d39ad to
e42d6ea
Compare
ab4936a to
86364a0
Compare
dc68741 to
53aa077
Compare
17e9d16 to
18e75de
Compare
53aa077 to
3f1dd88
Compare
3f1dd88 to
e6bbf75
Compare
18e75de to
6d8f3be
Compare
This was referenced Oct 23, 2025
Collaborator
Author
|
Closed in favour of v2 Editor migration. See #2028 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Replace all task/input/output -> node id conversions with the new NodeManager. In other words, the
nodeIdUtilsfile has been replaced with the new NodeManager.i.e. replace all instances of
inputNameToNodeId,outputNameToNodeId, andtaskIdToNodeId(and the reverse operations) with the NodeManager'sgetNodeIdandgetRefIdmethods (orgetInputNodeIdandgetOutputNodeIdvia theuseNodeManagerhook). This also includes replacement of all methods dealing with Handle ids as well, and these have been brought into the node manager viagetHandleNodeIdandgetHandleInfo.inputNameToNodeId-->getInputNodeIdoutputNameToNodeId-->getOutputNodeIdtaskIdToNodeId-->getTaskNodeIdAll nodes & handles will now have a uniquely assigned node id for use in ReactFlow and via the NodeManager this is mapped back to their respective id in the component spec. For handles they are mapped to the parent object they are one.
Also includes a few minor refactors such as
removeEdge, to make things more human-readable.Includes some AI-generated updates to tests.
Closes Shopify/oasis-frontend#261
Type of Change
Checklist
Test Instructions
etc