Skip to content

fix(auth): enforce client certificates and configured CRL checks - #464

Merged
mbuckton merged 7 commits into
developmentfrom
MAPS-0-tls-dtls-security
Aug 7, 2026
Merged

fix(auth): enforce client certificates and configured CRL checks#464
mbuckton merged 7 commits into
developmentfrom
MAPS-0-tls-dtls-security

Conversation

@mbuckton

@mbuckton mbuckton commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • preserve required/wanted client-certificate policy on generated SSL engines
  • wrap the configured X.509 trust manager so normal CA validation and CRL checking both execute
  • fail the handshake when revocation status cannot be established
  • retain the existing public CRL trust-manager constructor with safe default CA validation
  • add regression tests for client-auth precedence and CRL composition

Companion change

Server transport/configuration fixes: Maps-Messaging/mapsmessaging_server#2162

Verification

Focused tests were added under src/test/java/io/mapsmessaging/security/ssl. This managed environment cannot run the Maven build because the repository and Maven dependency cache are not available locally; the repository currently exposes no PR workflow/status check.

SECURITY: TLS client authentication and CRL enforcement

SECURITY: enforce configured TLS trust policy
SECURITY: retain CA validation when CRL checking is enabled
SECURITY: reject unverifiable revocation status
SECURITY: pair legacy construction with default CA validation
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4497a581-d02f-4299-9a73-d82c449a5dff

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mbuckton
mbuckton marked this pull request as ready for review August 7, 2026 05:49
@mbuckton
mbuckton merged commit 7b392c2 into development Aug 7, 2026
2 checks passed
@mbuckton
mbuckton deleted the MAPS-0-tls-dtls-security branch August 7, 2026 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant