Skip to content

Enforce required TLS client certificates - #463

Closed
mbuckton wants to merge 2 commits into
mainfrom
agent/enforce-client-certificate-authentication
Closed

Enforce required TLS client certificates#463
mbuckton wants to merge 2 commits into
mainfrom
agent/enforce-client-certificate-authentication

Conversation

@mbuckton

@mbuckton mbuckton commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • configure exactly one SSLEngine client-authentication mode
  • give required client authentication precedence over optional authentication
  • add regression coverage for all required/wanted combinations

Root cause

SSLEngine client-authentication setters override each other. Calling setWantClientAuth after setNeedClientAuth cleared the required setting, including when wanted was false.

Impact

TLS servers configured with clientCertificateRequired=true now retain mandatory client-certificate authentication and reject peers that do not provide an acceptable certificate.

Validation

Added unit assertions for disabled, wanted, required, and conflicting required/wanted configurations.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 68f7b511-6098-4e0b-b374-de33c9a8f651

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

mbuckton commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by #464, rebuilt from the development branch with the broader TLS/CRL security fixes and regression coverage.

@mbuckton mbuckton closed this Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant