Skip to content

Enforce required TLS client certificates #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mbuckton wants to merge 2 commits into from
Closed

Enforce required TLS client certificates #463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e134b32
Enforce required client certificates
mbuckton Aug 7, 2026
172b15b
Test client certificate authentication modes
mbuckton Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/main/java/io/mapsmessaging/security/ssl/SslHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,10 +153,14 @@ public static SSLContext createContext(String context, ConfigurationProperties c
return sslContext;
}

public static SSLEngine createSSLEngine(SSLContext sslContext, ConfigurationProperties tls){
public static SSLEngine createSSLEngine(SSLContext sslContext, ConfigurationProperties tls) {
SSLEngine sslEngine = sslContext.createSSLEngine();
sslEngine.setNeedClientAuth(tls.getBooleanProperty("clientCertificateRequired", false));
sslEngine.setWantClientAuth(tls.getBooleanProperty("clientCertificateWanted", false));
boolean clientCertificateRequired = tls.getBooleanProperty("clientCertificateRequired", false);
if (clientCertificateRequired) {
sslEngine.setNeedClientAuth(true);
} else {
sslEngine.setWantClientAuth(tls.getBooleanProperty("clientCertificateWanted", false));
}
return sslEngine;
}

Expand Down
21 changes: 21 additions & 0 deletions src/test/java/io/mapsmessaging/security/ssl/SslHelperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,25 @@ void simpleHelperTest() throws Exception {
SSLEngine sslEngine = SslHelper.createSSLEngine(sslContext, new ConfigurationProperties() );
Assertions.assertNotNull(sslEngine);
}

@Test
void clientCertificateAuthenticationModesAreMutuallyExclusive() throws Exception {
SSLContext sslContext = SSLContext.getDefault();

assertClientAuthenticationMode(sslContext, false, false, false, false);
assertClientAuthenticationMode(sslContext, false, true, false, true);
assertClientAuthenticationMode(sslContext, true, false, true, false);
assertClientAuthenticationMode(sslContext, true, true, true, false);
}

private void assertClientAuthenticationMode(SSLContext sslContext, boolean required, boolean wanted, boolean expectedRequired, boolean expectedWanted) {
ConfigurationProperties properties = new ConfigurationProperties();
properties.put("clientCertificateRequired", required);
properties.put("clientCertificateWanted", wanted);

SSLEngine sslEngine = SslHelper.createSSLEngine(sslContext, properties);

Assertions.assertEquals(expectedRequired, sslEngine.getNeedClientAuth());
Assertions.assertEquals(expectedWanted, sslEngine.getWantClientAuth());
}
}