Add SearchGUI support for InstaNovo and InstaNovo+#387
Open
BioGeek wants to merge 18 commits into
Open
Conversation
This was referenced Jun 22, 2026
…tabase A database is only required when a database search engine is selected; de novo only runs (including PeptideShaker post-processing) can now proceed without one. The PeptideShaker launch omits the -fasta_file argument when no database is set.
When an external tool (such as ThermoRawFileParser) cannot be started, report the cause and cancel the run instead of failing later with a null process NullPointerException.
ThermoRawFileParser writes .mzML output; request and look for that exact extension so the converted file is found on case-sensitive file systems (otherwise de novo engines reading the spectrum file directly could not find it).
752d105 to
a1d9188
Compare
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InstaNovo is a de novo peptide sequencing tool.
This PR adds SearchGUI support for InstaNovo v1.2.2 in three modes:
Changes
Adds GUI entries for:
InstaNovoInstaNovo+InstaNovo with refinementAdds GUI descriptions and documentation links for the new algorithms.
Adds advanced settings for:
Adds SearchCLI flags:
-instanovo-instanovo_plus-instanovo_refine-instanovo_folderAllows de novo-only InstaNovo runs without a FASTA database.
Keeps FASTA validation for database search engine runs.
Adds progress parsing for InstaNovo prediction output.
Handles non-zero InstaNovo process exits as failed runs.
Improves cancellation handling for external InstaNovo processes.
Adds documentation for local InstaNovo setup with
uv.De Novo End-To-End With PeptideShaker
Follow-up changes so a de novo only run flows all the way through to PeptideShaker:
-fasta_fileargument when launching PeptideShaker for a de novo only run..mzMLextension for ThermoRawFileParser output, matching what the tool actually writes, so converted spectra are found on case-sensitive file systems (de novo engines read the spectrum file directly).monois missing) instead of failing later with a null process NPE.Implementation Notes
.venv/bin/instanovo, theninstanovoin the selected folder, theninstanovofromPATH..instanovo.csv.instanovoplus.csv.instanovo.refined.csvScreenshots
Tests
Ran:
mvn -Dtest=eu.isas.searchgui.processbuilders.InstaNovoProcessBuilderTest,eu.isas.searchgui.cmd.SearchCLIInstaNovoTest,eu.isas.searchgui.gui.SearchGUIInstaNovoModelsTest test mvn -DskipTests -Dmaven.javadoc.skip=true packageMerge Order
Recommended order: