Add InstaNovo and InstaNovo+ import support#73
Open
BioGeek wants to merge 10 commits into
Open
Conversation
This was referenced Jun 22, 2026
On recent JDKs the Nimbus look and feel can throw a benign ClassCastException (ColorUIResource cannot be cast to Boolean in NimbusStyle.isOpaque) while building chart popup menus. The exception is still logged but no longer shown to the user, as it does not affect functionality.
ThermoRawFileParser writes mzML files with the canonical .mzML extension. Declaring the format ending as .mzML lets consumers find the converted file on case-sensitive file systems.
log4j-core was bumped to 2.25.4 while log4j-api stayed at 2.23.1, causing a NoSuchFieldError at runtime. Bump log4j-api to 2.25.4 to match.
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InstaNovo is a de novo peptide sequencing tool.
This PR adds support for normalized CSV output from InstaNovo v1.2.2 in three modes:
This PR forms the basis for a bunch of related PRs within the CompOmics ecosystem.
Changes
InstaNovoInstaNovo+InstaNovo with refinement.instanovo.csv.instanovoplus.csv.instanovo.refined.csvSupporting Fixes
Shared fixes needed for the InstaNovo de novo end-to-end flow (SearchGUI → PeptideShaker):
.mzML(the canonical extension the tool writes) so converted spectra are found on case-sensitive file systems.log4j-apito 2.25.4 to match the bumpedlog4j-core, fixing a runtimeNoSuchFieldError.ClassCastException(ColorUIResource cannot be cast to Boolean) thrown while building chart popup menus on recent JDKs.Implementation Notes
Tests
Ran:
mvn -Dtest=com.compomics.util.test.experiment.io.identifications.TestInstaNovoIdfileReader,com.compomics.util.test.parameters.identification.tool_specific.TestInstaNovoParameters test mvn -DskipTests -Dmaven.javadoc.skip=true installCovered by tests:
scan=tokens.Merge Order
Recommended order: