Add DeNovoGUI compatibility APIs to Utilities#74
Open
BioGeek wants to merge 12 commits into
Open
Conversation
On recent JDKs the Nimbus look and feel can throw a benign ClassCastException (ColorUIResource cannot be cast to Boolean in NimbusStyle.isOpaque) while building chart popup menus. The exception is still logged but no longer shown to the user, as it does not affect functionality.
ThermoRawFileParser writes mzML files with the canonical .mzML extension. Declaring the format ending as .mzML lets consumers find the converted file on case-sensitive file systems.
log4j-core was bumped to 2.25.4 while log4j-api stayed at 2.23.1, causing a NoSuchFieldError at runtime. Bump log4j-api to 2.25.4 to match.
This was referenced Jun 23, 2026
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds a narrow compatibility layer needed by the DeNovoGUI InstaNovo port after moving DeNovoGUI onto the newer Utilities line.
DeNovoGUI still uses several older Utilities API shapes, especially string-based spectrum keys and legacy PSM iteration helpers. This PR restores those compatibility entry points on top of the current Utilities implementation instead of copying local Utilities classes into DeNovoGUI.
Changes
Spectrum.getSpectrumKeySpectrum.getSpectrumFileSpectrum.getSpectrumTitlePsmIteratoras a small facade over the current spectrum-match iterator.Tests
Ran:
The main downstream verification is compiling and smoke-testing the DeNovoGUI branch against this Utilities branch.
Merge Order