Skip to content

Multiple imports for an import name #3033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Multiple imports for an import name #3033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/zarr/core/sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import os
import threading
from concurrent.futures import ThreadPoolExecutor, wait
from typing import TYPE_CHECKING, Any, TypeVar
from typing import TYPE_CHECKING, TypeVar

from typing_extensions import ParamSpec

Expand Down
4 changes: 1 addition & 3 deletions src/zarr/storage/_obstore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
import contextlib
import pickle
from collections import defaultdict
from collections.abc import Iterable
from typing import TYPE_CHECKING, Any, TypedDict
from typing import TYPE_CHECKING, TypedDict

from zarr.abc.store import (
ByteRequest,
Expand All @@ -14,7 +13,6 @@
Store,
SuffixByteRequest,
)
from zarr.core.buffer.core import BufferPrototype
from zarr.core.config import config

if TYPE_CHECKING:
Expand Down
5 changes: 1 addition & 4 deletions tests/test_group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1519,7 +1519,6 @@ def test_create_nodes_concurrency_limit(store: MemoryStore) -> None:
# if create_nodes is sensitive to IO latency,
# this should take (num_groups * get_latency) seconds
# otherwise, it should take only marginally more than get_latency seconds

with zarr_config.set({"async.concurrency": 1}):
start = time.time()
_ = tuple(sync_group.create_nodes(store=latency_store, nodes=groups))
Expand Down Expand Up @@ -2024,9 +2023,7 @@ def test_group_members_concurrency_limit(store: MemoryStore) -> None:
# if .members is sensitive to IO latency,
# this should take (num_groups * get_latency) seconds
# otherwise, it should take only marginally more than get_latency seconds
from zarr.core.config import config

with config.set({"async.concurrency": 1}):
with zarr_config.set({"async.concurrency": 1}):
start = time.time()
_ = group_read.members()
elapsed = time.time() - start
Expand Down