Skip to content

Multiple imports for an import name #3033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Multiple imports for an import name #3033

wants to merge 1 commit into from

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented May 4, 2025 •
edited
Loading

Suggested by DeepSource.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label May 4, 2025
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review May 4, 2025 08:39
dstansby
dstansby reviewed May 9, 2025
View reviewed changes
Copy link
Contributor

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there not a ruff rule we can enable to enforce this?

@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented May 10, 2025 •
edited
Loading

Pylint rule reimported / W0404 is not available as a ruff rule. Perhaps it overlaps with another rule, but I am unable to identify one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstansby dstansby dstansby left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DimitriPapadopoulos @dstansby