Skip to content

Update termthemes.json #2173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update termthemes.json #2173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion pkg/wconfig/defaultconfig/termthemes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,5 +174,29 @@
"foreground": "#e0def4",
"background": "#191724",
"cursor": "#524f67"
}
},
"Blue Matrix": {
"display:name": "Blue Matrix",
"display:order": 8,
"black": "#101116",
"red": "#ff5680",
"green": "#00ff9c",
"yellow": "#fffc58",
"blue": "#00b0ff",
"purple": "#d57bff",
"cyan": "#76c1ff",
"white": "#c7c7c7",
"brightBlack": "#686868",
"brightRed": "#ff6e67",
"brightGreen": "#5ffa68",
"brightYellow": "#fffc67",
"brightBlue": "#6871ff",
"brightPurple": "#d682ec",
"brightCyan": "#60fdff",
"brightWhite": "#ffffff",
"background": "#101116",
"foreground": "#00a2ff",
"selectionBackground": "#c1deff",
"cursorColor": "#76ff9f"
}
Comment on lines +178 to +201
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Ensure theme identifier and property naming consistency

  • The JSON key "Blue Matrix" contains spaces and uppercase letters. Use a lowercase slug (e.g., "blue-matrix") to follow the existing theme ID pattern and avoid potential runtime lookup issues.
  • Replace custom properties "purple"/"brightPurple" with "magenta"/"brightMagenta" to align with the other theme entries.
  • Rename "cursorColor" to "cursor" for consistency with existing themes.
  • Verify if "gray" and "cmdtext" keys are required by the application; if so, consider adding them here as in other entries.
-    "Blue Matrix": {
+    "blue-matrix": {
      "display:name": "Blue Matrix",
      "display:order": 8,
      "black": "#101116",
      "red": "#ff5680",
      "green": "#00ff9c",
      "yellow": "#fffc58",
      "blue": "#00b0ff",
-      "purple": "#d57bff",
+      "magenta": "#d57bff",
      "cyan": "#76c1ff",
      "white": "#c7c7c7",
      "brightBlack": "#686868",
      "brightRed": "#ff6e67",
      "brightGreen": "#5ffa68",
      "brightYellow": "#fffc67",
      "brightBlue": "#6871ff",
-      "brightPurple": "#d682ec",
+      "brightMagenta": "#d682ec",
      "brightCyan": "#60fdff",
      "brightWhite": "#ffffff",
      "background": "#101116",
      "foreground": "#00a2ff",
      "selectionBackground": "#c1deff",
-      "cursorColor": "#76ff9f"
+      "cursor": "#76ff9f",
+      // Optional keys for completeness:
+      // "gray": "<hex>",
+      // "cmdtext": "<hex>"
    }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"Blue Matrix": {
"display:name": "Blue Matrix",
"display:order": 8,
"black": "#101116",
"red": "#ff5680",
"green": "#00ff9c",
"yellow": "#fffc58",
"blue": "#00b0ff",
"purple": "#d57bff",
"cyan": "#76c1ff",
"white": "#c7c7c7",
"brightBlack": "#686868",
"brightRed": "#ff6e67",
"brightGreen": "#5ffa68",
"brightYellow": "#fffc67",
"brightBlue": "#6871ff",
"brightPurple": "#d682ec",
"brightCyan": "#60fdff",
"brightWhite": "#ffffff",
"background": "#101116",
"foreground": "#00a2ff",
"selectionBackground": "#c1deff",
"cursorColor": "#76ff9f"
}
"blue-matrix": {
"display:name": "Blue Matrix",
"display:order": 8,
"black": "#101116",
"red": "#ff5680",
"green": "#00ff9c",
"yellow": "#fffc58",
"blue": "#00b0ff",
"magenta": "#d57bff",
"cyan": "#76c1ff",
"white": "#c7c7c7",
"brightBlack": "#686868",
"brightRed": "#ff6e67",
"brightGreen": "#5ffa68",
"brightYellow": "#fffc67",
"brightBlue": "#6871ff",
"brightMagenta": "#d682ec",
"brightCyan": "#60fdff",
"brightWhite": "#ffffff",
"background": "#101116",
"foreground": "#00a2ff",
"selectionBackground": "#c1deff",
"cursor": "#76ff9f",
// Optional keys for completeness:
// "gray": "<hex>",
// "cmdtext": "<hex>"
}
🤖 Prompt for AI Agents 
In pkg/wconfig/defaultconfig/termthemes.json from lines 178 to 201, rename the
theme key "Blue Matrix" to a lowercase slug "blue-matrix" to maintain
consistency. Change the color properties "purple" and "brightPurple" to
"magenta" and "brightMagenta" respectively. Rename the "cursorColor" property to
"cursor" to match other themes. Additionally, check if "gray" and "cmdtext"
properties are needed and add them if required for consistency.

}
Loading